Websites from history in "popular websites" section.

Open
#516 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
18/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Quiet
Domain
mobile, search

Research direction

The payload names no files, tests or entry points, so a newcomer has to locate the address bar autocompletion and the popular websites list in the codebase first. The issue asks for a design decision rather than one change: whether history and bookmarks feed the popular websites list, and how that list replaces autocompletion. Done would mean a maintainer-agreed design, so confirm the approach in the thread before writing code.

Written by the indexing model from the issue text.

Description

enhancement needs-triage

If we show also websites from history in popular websites section, and websites from bookmarks, we can choose tp disable autocompletion, because "popular websites" section will do everything autocompletion does and even more. But only main domains, not a distinct webpages.

Advantages of that.

  1. It will allow to go by click to alternative websites when autocompletion can have only one: for example if you type git you wi be suggested both with gilab and github, while autocompletion cant do more than one simultaniously. Which is already partially working, only with popular websites.
  2. If you want to search for github, autocompletion will complete it to github.com and you have to remove extra letters to not visit github but search for it.

So i suggest to make popular website section into sort of website database, where you will have initial popular websites and websites that user visited, so it always will be able to suggest corrwct websites, from history, bookmarks or just popular ones, and user will be able to disable autocompletion in adress bar entirelly. Even though autocompletion has its flaws that i described, disabling it currently is not viable untill you have an alternative that is good enough, which is point of this suggestion.

Dominant language
Dart
Stars
1k
Forks
41
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from FaFre/WebLibre

All issues in FaFre/WebLibre

Similar issues

More Dart issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.