Option to move search engine suggestions into adress bar.

Open
#489 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
15/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Quiet
Tech stack
android, dart
Domain
mobile, search

Research direction

The issue names no files, tests or entry points, so start by finding where the address bar and search suggestion list are implemented in the Dart/Android codebase. The request is a UI behaviour change (a search-engine icon that lights up when suggestions exist and switches engines on tap), and it has no comments or maintainer decision yet. Done would mean the maintainers agree on the interaction design first, and only then an implementation.

Written by the indexing model from the issue text.

Description

enhancement needs-triage

Whenever we want to use search engine suggestions we need them to be very close to adresss bar, but when we dont need them we want them to not be visible and not take space and not distract. So i think i have an idea how to do it.

When we click on search engine suggestion it brings icon, but on default search engine there is no icon, and adress bar is clean. We could utilize that.

Lets imahine google is our default search engine. We need to have have search engine icon always visible. We for example start to type "wikip". Search engine suggestion detects possible suggestion, and list is not empty. At that moment search engine icon's outliner (google icon in our case) lights up, and we know wr have search engine suggestions avialable. We click google icon and from popup or drop down list choose wikipedia, and icon changes to wikipedia. But if we dont want to use search enhine suggestions we can ignore glowing animation, and use other suggestions that will be immediatelly under adress bar.

Dominant language
Dart
Stars
1k
Forks
41
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from FaFre/WebLibre

All issues in FaFre/WebLibre

Similar issues

More Dart issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.