Add metamethods for bitwise operators and remove `__gc`
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Start with the linked Lua ltm.c reference around line 43, then locate the corresponding metamethod implementation in this repository. Verify the bitwise metamethod names, including the bshr spelling in the issue, and remove __gc; done means the operators are supported and __gc is no longer recognized.
Written by the indexing model from the issue text.
Description
GPG added metamethods for bitwise operators which I didn't do when I added them. The methods are called
"__band", "__bor", "__bshl", "bshr"
They also removed the __gc metamethod.
For inspiration only, the implementation here should not necessarily be taken as a reference.
https://github.com/lua/lua/blob/75ea9ccbea7c4886f30da147fb67b693b2624c26/ltm.c#L43
- Dominant language
- C
- Stars
- 1
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from FAForever/lua-lang
-
Pre-allocation syntax of tablesMay be free again A pull request for this issue was closed without being merged. Open
Difficulty 3/5 1-2 days Newbie friendliness 35/100
-
Difficulty 3/5 1-2 days Newbie friendliness 38/100
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
All issues in FAForever/lua-lang
Similar issues
-
good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
tmewett/BrogueCE#929 · 1 comment ·
Maintainers usually reply within 1 day
-
bug : find_key() compares kty against "ocy" instead of "oct", breaking kid-less HS256 verificationOpen
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
OpenPrinting/cups#1756 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 76/100
SteamGridDB/SGDBoop#147 ·