Fix the flaky sandbox canary log test (random id contains 777)
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 88/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- typescript
- Domain
- testing-qa
Research direction
Start with dispatcher/src/launchers/sandbox-canary.test.ts lines 290–292 and check how the test sets the platform error text and generates random ids. Run the focused test, repeating it or varying the seed if available. Done means it still fails when the platform text is logged, but passes reliably when that text is not logged, regardless of random ids.
Written by the indexing model from the issue text.
Description
Problem
dispatcher/src/launchers/sandbox-canary.test.ts:290-292 makes the stop fail with the platform text "platform text 777". It then asserts expect(logger.text()).not.toContain("777").
The logged text also carries random ids. When one of them happens to contain 777, the test fails although nothing leaked. This happened on PR #462, an unrelated change, and the test passed on a rerun.
Fix
Use a sentinel that cannot appear in a random id. For example a word like PLATFORM_SENTINEL_TEXT, or a fixed id source in the test. Keep the guarantee that the platform text is never logged.
Test cases
- T01: the test fails if the platform error text is logged, and passes otherwise, independent of random ids (seed or repeat the run to show it).
Related: #308, the same pattern in the LLM key browser journey.
- Dominant language
- TypeScript
- Stars
- 0
- Forks
- 1
- Avg merge
- 1h 17m
- Merged PRs (30d)
- 246
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ExpidetGames/code-reviewer
-
area: app type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
ExpidetGames/code-reviewer#308 ·
Maintainers usually reply within 1 day
-
type: docs
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
ExpidetGames/code-reviewer#94 ·
Maintainers usually reply within 1 day
-
area: runner type: bug
Difficulty 3/5 1-2 days Newbie friendliness 64/100
ExpidetGames/code-reviewer#483 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 49/100
ExpidetGames/code-reviewer#479 ·
Maintainers usually reply within 1 day
-
area: app type: chore
Difficulty 4/5 3-5 days Newbie friendliness 38/100
ExpidetGames/code-reviewer#478 ·
Maintainers usually reply within 1 day
All issues in ExpidetGames/code-reviewer
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
OpenPetsHQ/openpets#273 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
fritzprix/libr-agent#2161 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
blackboardsh/electrobun#581 ·
-
backlog-skill effort:xs frontend infra ready-for-agent
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
LucasSantana-Dev/Lucky#2862 ·
Maintainers usually reply within 1 day