Hosted deployment: remove the legacy runner loop and legacy claim payload
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 20/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- docker, typescript
- Domain
- api
Research direction
Start by confirming that #335 has landed and that one release of notice has passed, since the issue is blocked until then. The work is removing the legacy combined runner loop, its claim and complete path, and the legacy claim response that carries job input and secrets, while keeping the runner API at version 1. Done means the image smoke test (T01) finds no legacy loop, an old claim without the feature returns a documented error (T02), the split flow is unchanged (T03), and the release notes state the removal and required App version (T04).
Written by the indexing model from the issue text.
Description
Part of ##316. Later.
Problem
Once the split is the default and has been stable, the legacy combined loop and the legacy claim payload (job input and secrets in the claim response) are dead weight and a larger attack surface.
Design
Remove the legacy loop's claim and complete path and the legacy claim response after one release of notice. The runner API stays version 1; an old claim without the feature gets a documented error. All supported Apps must already have the new API.
Scope
Deletion, a documented error, docs, release notes.
Depends on
##335 and one release of notice.
Test cases
| ID | kind | level | case | expected |
|---|---|---|---|---|
| T01 | regression | image smoke | the image | contains no legacy loop |
| T02 | error | integration | an old claim without the feature | a documented error |
| T03 | regression | integration | split flow | unchanged |
| T04 | docs | review | release notes | state the removal and the required App version |
- Dominant language
- TypeScript
- Stars
- 0
- Forks
- 1
- Avg merge
- 1h 18m
- Merged PRs (30d)
- 186
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ExpidetGames/code-reviewer
-
area: app type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
ExpidetGames/code-reviewer#308 ·
Maintainers usually reply within 1 day
-
type: docs
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
ExpidetGames/code-reviewer#94 ·
Maintainers usually reply within 1 day
-
area: app post-mvp type: feature
Difficulty 5/5 Over a week Newbie friendliness 12/100
ExpidetGames/code-reviewer#339 ·
Maintainers usually reply within 1 day
-
area: runner post-mvp type: feature
Difficulty 5/5 Over a week Newbie friendliness 18/100
ExpidetGames/code-reviewer#338 ·
Maintainers usually reply within 1 day
-
area: runner post-mvp type: feature
Difficulty 5/5 Over a week Newbie friendliness 12/100
ExpidetGames/code-reviewer#337 ·
Maintainers usually reply within 1 day
All issues in ExpidetGames/code-reviewer
Similar issues
-
documentation good first issue
Difficulty 2/5 Half a day Newbie friendliness 72/100
sujithputta02/Esapay#13 ·
-
Share dialog: the address book's contact count reads "1 contacts" (no singular form in any language)Possibly taken @chibenwa claimed this today. Openai-driven-qa bug claude Cosmetic
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
linagora/twake-contacts-frontend#271 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Koenkk/zigbee2mqtt#33402 ·
Maintainers usually reply within 1 day
-
dx P2 platform Stellar Wave Wave 10
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
winsznx/routedock#579 · 1 comment ·
Maintainers usually reply within 1 day
-
area:ui effort:S enhancement priority:P2
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day