`dotnet format style --verify-no-changes` fails with naming violations and unnecessary imports
Maintainers usually reply within 7 days
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 80/100
Research direction
Start with the listed files: the four core library files with IDE1006 diagnostics and the five test files with IDE0005 diagnostics. Read the repository's .editorconfig and inspect the named fields, constructor parameter, and using directives; check how Analyzed.cs is compiled by the analyzer tests. Run dotnet format style --verify-no-changes from the repository root to confirm completion, then verify the analyzer tests still pass.
Written by the indexing model from the issue text.
Description
Describe the bug
Running the style verification command from the repository root reports IDE1006 naming violations in four core library files and IDE0005 errors in five test files. The source does not satisfy the repository's existing .editorconfig rules, causing the verification command to fail.
To reproduce
-
Use an Eventuous checkout at revision
60a76433. -
From the repository root, run:
dotnet format style --verify-no-changes -
Observe the naming warnings and unnecessary-using errors below.
Expected behavior
The command exits successfully without reporting style violations or requiring source changes. The existing analyzer tests should continue to pass.
Actual behavior
The command reports the following diagnostics. Paths are relative to the repository root; repeated diagnostics and project-path suffixes have been omitted for readability. Line numbers refer to the affected revision.
src/Core/src/Eventuous.Diagnostics/EventuousDiagnostics.cs(18,38): warning IDE1006: Naming rule violation: These words must begin with upper case characters: listener
src/Core/src/Eventuous.Persistence/ExpectedStreamVersion.cs(14,36): warning IDE1006: Naming rule violation: The first word, 'Value', must begin with a lower case character
src/Core/src/Eventuous.Serialization/EventSerializer.cs(13,30): warning IDE1006: Naming rule violation: Prefix '_' is not expected
src/Core/src/Eventuous.Shared/TypeMap/TypeMap.cs(51,25): warning IDE1006: Naming rule violation: Prefix '_' is not expected
src/Core/test/Eventuous.Tests.Shared.Analyzers/Analyzed.cs(4,1): error IDE0005: Using directive is unnecessary.
src/Postgres/test/Eventuous.Tests.Postgres/Subscriptions/GapSkipTimeoutTest.cs(5,1): error IDE0005: Using directive is unnecessary.
src/Postgres/test/Eventuous.Tests.Postgres/Subscriptions/GapAgeReleaseWhileRunningTest.cs(5,1): error IDE0005: Using directive is unnecessary.
src/Postgres/test/Eventuous.Tests.Postgres/Subscriptions/GapRemediationBeforeSkipTest.cs(5,1): error IDE0005: Using directive is unnecessary.
src/Sqlite/test/Eventuous.Tests.Sqlite/Metrics/MetricsFixture.cs(9,1): error IDE0005: Using directive is unnecessary.
Environment
- OS: Linux
- .NET SDK:
10.0.201 - Solution:
Eventuous.slnx - Affected projects target
net10.0,net9.0, andnet8.0; diagnostics repeat across target frameworks.
Additional context
The naming violations concern the static fields listener, _default, and _index, and the StreamReadPosition constructor parameter Value. The public Value property is separate from the constructor parameter.
Analyzed.cs is also loaded directly as source by the analyzer tests. Its System, System.Collections.Generic, and System.Threading.Tasks imports duplicate SDK implicit usings during a normal project build, but the standalone Roslyn compilation needs equivalent imports. Removing the redundant directives should preserve that test compilation context.
- Dominant language
- C#
- Stars
- 512
- Forks
- 99
- Avg merge
- 5d 6h
- Merged PRs (30d)
- 5
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Eventuous/eventuous
-
MongoDB integration tests fail on newer GitHub Actions runner kernelsPossibly taken @nmummau claimed this 1 day ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Eventuous/eventuous#626 · 2 comments ·
Maintainers usually reply within 7 days
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
Eventuous/eventuous#627 · 1 comment ·
Maintainers usually reply within 7 days
-
SQL Server: `append_events` does not need the `@inserted` table variablePossibly taken @nmummau claimed this 7 days ago. Open
Difficulty 3/5 1-2 days Newbie friendliness 20/100
Eventuous/eventuous#619 · 1 comment ·
Maintainers usually reply within 7 days
-
SQL Server: stream reads do one key lookup per event, and `IDX_EventsStream` duplicates `UQ_StreamIdAndStreamPosition`Possibly taken @nmummau claimed this 7 days ago. Open
Difficulty 3/5 1-2 days Newbie friendliness 18/100
Eventuous/eventuous#618 · 1 comment ·
Maintainers usually reply within 7 days
-
SQL Server: every stream lookup by name does a key lookup to get `Version`Possibly taken @nmummau claimed this 7 days ago. Open
Difficulty 3/5 1-2 days Newbie friendliness 25/100
Eventuous/eventuous#617 · 1 comment ·
Maintainers usually reply within 7 days
All issues in Eventuous/eventuous
Similar issues
-
The test-platform skill doesn't say what three of its failures look likePossibly taken @yasmoradi claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
bitfoundation/bitplatform#14022 ·
Maintainers usually reply within 1 day
-
area-TableView bug needs-triage team-Controls
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
microsoft/microsoft-ui-xaml#12351 · 1 comment ·
Maintainers usually reply within 2 days
-
AudioClient and ImageClient file path overloads send the full local path as the multipart file namePossibly taken @sebxt claimed this today. Openarea: audio area: images feature-request
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
openai/openai-dotnet#1453 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
Maintainers usually reply within 1 day
-
Runtime diagnostics settings report canManage=true for every callerPossibly taken A pull request linked to this issue is open or already merged. Openneeds-triage
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
elsa-workflows/elsa-foundation#3130 ·
Maintainers usually reply within 1 day