Read the Java pin from .sdkmanrc
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 3/5
- Estimated time
- Half a day
- Newbie friendliness
- 74/100
Research direction
Start with the java row of RUNTIMES and the existing pins in src/devready/checks/runtimes.py, then read explain.py, docs/checks.md and the CHANGELOG format. Add a _sdkman("java") extractor that reads only the java= line of .sdkmanrc and returns the leading version digits, placed after .java-version. Done when the unit tests cover java=21.0.2-tem, comments, a missing java line and an old version, and pytest, ruff check and ruff format --check pass.
Written by the indexing model from the issue text.
Description
Problem: Java teams using SDKMAN pin the JDK in .sdkmanrc:
java=21.0.2-tem
DevReady already checks Java (.java-version, pom.xml, build.gradle) but ignores .sdkmanrc.
Do:
- Add a pin to the
javarow ofRUNTIMESinsrc/devready/checks/runtimes.py:("project.java.sdkman", ".sdkmanrc", _sdkman("java"), Status.WARN). _sdkman(name)returns an extractor that reads only thejava=line (ignore comments and other candidates) and returns the leading\d+(\.\d+){0,2}, dropping the vendor suffix (-tem,-graal).- Put it after
.java-versionin the list (the first pin found wins). - Add the
explain.pyentry, adocs/checks.mdrow, a CHANGELOG line and unit tests (java=21.0.2-tem, comments, no java line, too old).
Done when:
.sdkmanrcwithjava=21.0.2-temand Java 17 installed gives onewarnshowing21.0.2..sdkmanrcwith onlygradle=8.7gives no Java pin result.
Done when: see the list above, plus pytest, ruff check and ruff format --check pass.
Notes:
- Read-only: never execute project files, never echo file contents; only a validated version or spec reaches the report.
- No network, no new runtime dependencies (Python >= 3.10 stdlib only).
- Comment below to claim it and I will assign you.
- Dominant language
- Python
- Stars
- 2
- Forks
- 3
- Avg merge
- 10h 51m
- Merged PRs (30d)
- 40
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Evalogical-Inc/devReady
-
good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Evalogical-Inc/devReady#71 ·
Maintainers usually reply within 1 day
-
enhancement good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Evalogical-Inc/devReady#66 ·
Maintainers usually reply within 1 day
-
enhancement good first issue
Difficulty 2/5 3-5 days Newbie friendliness 72/100
Evalogical-Inc/devReady#61 ·
Maintainers usually reply within 1 day
-
good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
Evalogical-Inc/devReady#72 ·
Maintainers usually reply within 1 day
-
enhancement good first issue help wanted
Difficulty 3/5 1-2 days Newbie friendliness 72/100
Evalogical-Inc/devReady#69 ·
Maintainers usually reply within 1 day
All issues in Evalogical-Inc/devReady
Similar issues
-
Email validation accepts a trailing newlinePossibly taken @marcello-pichini claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
dbt-labs/spark-utils#51 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
bug frontend
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
vendrabuck/HERD#1419 ·
Maintainers usually reply within 1 day