pre-push gate can hang on load-sensitive SLA test while embedding backlog drains
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 58/100
Research direction
Start with tests/test_arbitration.py::test_real_concurrent_writers_keep_interactive_store_searchable_under_sla and trace how the mandatory pre-push hook selects it. Read AGENTS.md alongside the existing exclusions for test_vector_store.py and test_engine.py, then compare the timeout and reclassification options. Done means the pre-push path no longer silently hangs under embedding load and communicates the retry or scope choice clearly.
Written by the indexing model from the issue text.
Description
During the fleet gitignore sweep (2026-08-09), the mandatory pre-push full suite hung >20 min in tests/test_arbitration.py::test_real_concurrent_writers_keep_interactive_store_searchable_under_sla (its own round-trip SLA is 2s). Process sample showed NumPy/GIL work — consistent with the bge embedding model saturating CPU while the W2.5 backlog drain was running, starving the test's concurrent writers.
Standalone repro after load subsided: passes in 3.04s. So the test is correct but load-sensitive, and it sits in the mandatory pre-push path.
Proposed fixes (either):
- Bound it:
pytest-timeouton this test in the pre-push hook, with a clear "machine under embedding load — retry or use changed-only scope" message instead of a silent hang. - Reclassify it alongside the real-DB deliberate-check set excluded from worker pre-push (AGENTS.md already excludes
test_vector_store.py/test_engine.py).
Workaround used: BRAINLAYER_PREPUSH_SCOPE=changed-only (documented scoped path) for the gitignore-only push (#688).
Filed by brainlayerClaude lead (Fable 5).
🤖 Generated with Claude Code
- Dominant language
- Python
- Stars
- 9
- Forks
- 7
- Avg merge
- 2h 8m
- Merged PRs (30d)
- 211
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from EtanHey/brainlayer
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
EtanHey/brainlayer#999 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
EtanHey/brainlayer#986 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
EtanHey/brainlayer#985 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
EtanHey/brainlayer#982 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
EtanHey/brainlayer#676 ·
Maintainers usually reply within 1 day
All issues in EtanHey/brainlayer
Similar issues
-
[Bug] @deck.gl/arcgis dist import resolves to unpublished @deck.gl/core source path (9.3.11, 9.4.0)Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
workflow: a tick's dispatch counts as 'only this step', and no review self-grants a round unattendedOpenworkflow
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
kristofdegrave/homeassistant-smart-charging#1505 ·
Maintainers usually reply within 1 day
-
metadata submission
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
canonical/content-cache-operator#163 · 1 comment ·
Maintainers usually reply within 1 day
-
[submission]Opensubmission
Difficulty 1/5 Under an hour Newbie friendliness 65/100
leanprover/lean-eval-submissions#1852 ·
Maintainers usually reply within 1 day