Disc in Jukebox gets deletet with pipes

Open
#1,289 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
java
Domain
game-dev

Research direction

Start in src/main/java/com/sk89q/craftbook/mechanics/pipe/Pipes.java around line 177, then reproduce the issue with a pipe feeding a jukebox as described. Verify the behavior for both an empty and already occupied jukebox. Done means a disc is inserted only when the jukebox is empty, without deleting an existing disc.

Written by the indexing model from the issue text.

Description

status:pending type:bug

Versions

CraftBook version: 3.10.5
Bukkit version: 1.18.1

Describe the bug
If you pipe in a music disc into a jukebox it only works if a disc is already in the jukebox. It also deletes the old disc when the new one is insertet.

To Reproduce

  • create a simple pipe system
  • put a jukebox to the end
  • try to pipe a disk into the empty jukebox
  • add disc to the jukebox
  • activate the pipe again

Expected behavior

  • it should be vise versa i think
  • only pipe in the disc when the jukebox is empty so the disc gets not deleted

Additional context

https://github.com/EngineHub/CraftBook/blob/d8a3e9dad63b5a59eab48afa45e85a823083e2a6/src/main/java/com/sk89q/craftbook/mechanics/pipe/Pipes.java#L177

Dominant language
Java
Stars
320
Forks
165
Avg merge
6d 21h
Merged PRs (30d)
2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from EngineHub/CraftBook

All issues in EngineHub/CraftBook

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.