Malformed Jukebox-logic allows to duplicate discs indefinitely

Open
#1,361 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
java
Domain
game-dev

Research direction

Start by reproducing the duplication with two Jukeboxes, sticky and normal pistons, glass-block connections, and an input clock as described. Inspect the Jukebox logic for both sucking and putting behavior; done means the disc is transported to the other Jukebox without repeated drops or duplication, including when containers are absent or full.

Written by the indexing model from the issue text.

Description

status:pending type:bug
CraftBook Version

craftbook-3.10.13-SNAPSHOT

Platform Version

Paper version 1.21.10-101-main@893ea74

Confirmations
  • I am using the most recent Minecraft release.
  • I am using a version of WorldEdit compatible with my Minecraft version.
  • I am using a version of CraftBook compatible with my Minecraft version.
  • I am using the latest or recommended version of my platform software.
  • I am NOT using a hybrid server, e.g. a server that combines Bukkit and Forge. Examples include Arclight, Mohist, and Cardboard.
  • I am NOT using a fork of WorldEdit, such as FastAsyncWorldEdit (FAWE) or AsyncWorldEdit (AWE)
Bug Description

Since the logic of Jukeboxes is malformed both while sucking and while putting, one can duplicate discs indefinitely. Here's a short preview outlining the situation:

https://streamable.com/po7ze6

This also works if the pipe simply had either no containers attached, or if all of these containers couldn't hold another of the disc in question.

Expected Behavior

The disc should simply be transported to the other Jukebox.

Reproduction Steps
  1. Set up two empty Jukeboxes, one on a sticky- and one on a normal piston
  2. Connect the pistons with glass-blocks
  3. Add an input-clock (or clock manually)
  4. Put a disc into the input - notice how it is dropped over and over again
  5. Remove the disc manually - now the cycle stops
Anything Else?

No response

Dominant language
Java
Stars
320
Forks
165
Avg merge
6d 21h
Merged PRs (30d)
2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from EngineHub/CraftBook

All issues in EngineHub/CraftBook

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.