Better handling of enchantments

Open
#233 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
java
Domain
cli, game-dev

Research direction

Start by reading InventoryComponent and the existing /item, /give, and /enchantments command handling, then inspect org.bukkit.enchantments.Enchantment usage. Clarify where lookup functions belong before implementing the proposed /enchant command and user-input mapping; done means friendly enchantment names are accepted and resolved consistently.

Written by the indexing model from the issue text.

Description

CMDBOOK-2341 - Reported by Andy

Currently, you can only add enchantments with the /item and /give command if you enter the exact name from org.bukkit.enchantments.Enchantment. Those names aren't all very logical, and some doesn't correspond well to what they are generally called (Which is why the /enchantments command was added I suppose).

I would like to do something about this, and add an /enchant command in InventoryComponent based off the vanilla Minecraft-command with some improvements. In addition to the command handling there would need to be a way to transform user input to Enchantment-values/IDs.

Is this something you might be interested in? Additionally, I'm unsure as to where to send the PR in terms of the lookup-functions. I feel that it might be better to put this class in package com.sk89q.worldedit.blocks since the rest of the Item and Block-class/functions are there, where it may be used by WorldEdit/WorldGuard as well should there ever be a need to (/searchitem is a possibility).

Dominant language
Java
Stars
151
Forks
104
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from EngineHub/CommandBook

All issues in EngineHub/CommandBook

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.