Create clobbers a concurrently-created file
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
Research direction
The bug is in the create-file helper in Files.go, which overwrites a file that appeared while the user was on the confirmation prompt of the file edit tool. Start by reading that helper and the confirmation flow that calls it, then reproduce by creating the target file during the prompt. Done when a file that appeared during confirmation is either not overwritten or the user is warned first, for example through an O_EXCL open that returns an error. The issue leaves the approach open, so confirm the intended behaviour with the maintainer before choosing one.
Written by the indexing model from the issue text.
Description
##What
Create a file is now under edit file tool. Therefore if a user creates a file while waiting in the confirmation stage it will clobber the file.
##Where
Files.go in createFilehelper
##What should happen
- should have some recheck if the file has changed
- prompt the user if there is content that will be overwritten
- could implement a O_EXCL flag as well to get error if it appears during confirmation
- Dominant language
- Go
- Stars
- 1
- Forks
- 2
- Avg merge
- 1h 46m
- Merged PRs (30d)
- 6
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Edwin-metcalf/MetCode
-
enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Edwin-metcalf/MetCode#16 ·
-
testing
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Edwin-metcalf/MetCode#9 ·
-
Add a MakefileOpenenhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Edwin-metcalf/MetCode#8 ·
-
Add a --host flagOpenenhancement
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Edwin-metcalf/MetCode#7 ·
-
Add a --version flagOpenenhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Edwin-metcalf/MetCode#6 ·
All issues in Edwin-metcalf/MetCode
Similar issues
-
Say in the changelog that the text-index update cannot be rolled backPossibly taken @praetorianer777 claimed this today. Open
Difficulty 1/5 Under an hour Newbie friendliness 88/100
praetorianer777/GoTome#275 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
SAP/crossplane-provider-btp#1118 ·
Maintainers usually reply within 1 day
-
benchmark: `make setup` fails because audit-exporter builds with Go 1.25.0 while go.mod requires 1.26.0Possibly taken @xsvm claimed this today. Open
Difficulty 1/5 Under an hour Newbie friendliness 84/100
volcano-sh/volcano#6097 · 1 comment ·
Maintainers usually reply within 1 day
-
area/infra backlog bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
praetorianer777/Stator#417 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day