gameserver.cpp: catch(...) at protobuf/JSON parse site blocks reporting the real error
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
Research direction
Read AGENTS.md's CPP-MINGW-ADDENDUM, then inspect src/runtime/server/gameserver.cpp around line 1281 and the nearby protobuf/JSON parse call. Identify the exception type thrown there, replace the ellipsis catch with a typed catch, and verify the downstream Warning reports the exception reason through e.what().
Written by the indexing model from the issue text.
Description
Found while auditing log message quality in src/runtime/server/gameserver.cpp (repo-wide log audit).
Around line 1281 there's a catch (...) (ellipsis catch), which is a Hard Stop violation per AGENTS.md's CPP-MINGW-ADDENDUM ("Catch ... (ellipsis catch). Every catch block must name the type."). The adjacent Warning at line ~1282 currently can't report the actual parse error because the exception type is erased by the catch-all.
Fix direction: name the actual exception type being thrown at that call site (likely a nlohmann::json parse exception or similar, based on surrounding code) and catch that specifically, so the Warning can include e.what(). Not fixed as part of the log-audit commit since changing a catch clause is a structural code change, not a message-content edit — but the log line downstream of it can't be properly fixed (per this audit's own Rule 9 — error paths must log the error code/reason) until this is addressed.
- Dominant language
- C
- Stars
- 2
- Forks
- 2
- Avg merge
- 3h 8m
- Merged PRs (30d)
- 2
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from EchoTools/nevr-runtime
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
EchoTools/nevr-runtime#27 ·
-
crash-handler plugin: MH_ERROR_ALREADY_INITIALIZED treated as fatal, unlike every sibling pluginOpen
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
EchoTools/nevr-runtime#26 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
EchoTools/nevr-runtime#35 ·
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
EchoTools/nevr-runtime#34 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
EchoTools/nevr-runtime#33 ·
All issues in EchoTools/nevr-runtime
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
microsoft/ebpf-for-windows#5604 ·
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 84/100
AcademySoftwareFoundation/openexr#2683 ·
Maintainers usually reply within 1 day