echovr-reconstruction: CServerConfig.h still says sizeof(EntrantData) == 0xA0

Closed
  • Is something wrong?
#112 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
c
Domain
reverse-engineering

Research direction

Start by reading echovr-reconstruction/src/NRadEngine/Network/CServerConfig.h and compare its EntrantData size comment with the 0xD8 stride evidence cited from ReVault disassembly. The issue says the corresponding ABI definition was fixed in src/abi/echovr.h by PR #111; check the reconstruction repo and its ReVault annotations too. Done means the stale 0xA0 documentation is corrected to reflect the 0xD8 stride.

Written by the indexing model from the issue text.

Description

documentation

Found during #38's fix (PR #111). echovr-reconstruction/src/NRadEngine/Network/CServerConfig.h still documents EntrantData as 0xA0 bytes. The real stride, confirmed via ReVault disassembly at 3 call sites (0x14061665d, 0x1406082c9, 0x14061698f, all ... 0xd8), is 0xD8 bytes — fixed in this repo's src/abi/echovr.h (PR #111), but the reconstruction repo and its ReVault annotations weren't updated since that's outside this repo. Worth fixing there too so future agents don't re-derive this the hard way.

Dominant language
C++
Stars
2
Forks
5
Avg merge
4h 59m
Merged PRs (30d)
916

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from EchoTools/nevr-runtime

All issues in EchoTools/nevr-runtime

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.