installer: remove obsolete ensureVCRedist check and VC++ redistributable download
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 75/100
Research direction
Read installer/installer.nsi and installer/macros.nsh to locate the ensureVCRedist call and function, and check installer/locale/*.nsh for the listed strings. Remove those items, then review the installer sources to confirm no references to the VC redistributable check or download remain.
Written by the indexing model from the issue text.
Description
Background
The installer currently calls ensureVCRedist in installer.nsi to check for ucrtbase.dll and msvcp140.dll, prompting to download and run Microsoft Visual C++ Redistributable (vc_redist.*.exe) via inetc.
Reasons to remove
- Windows 10+ minimum requirement: Universal CRT (
ucrtbase.dll) has been an in-box Windows system component since Windows 10 build 10240 (2015). The check was originally for Windows 7 / 8.1 support (KB2999226), which has been dropped in PIME. - Static CRT linkage: Core PIME binaries (
PIMETextService.dll,PIMELauncher.exe,libIME2,libchewing) statically link the MSVC runtime (/MTviaCMAKE_MSVC_RUNTIME_LIBRARY). - Bundled runtime in Python: Python 3.12 embedded already ships
vcruntime140.dllinpython\python3. - Offline installations: Downloading
vc_redistviainetcduring installation fails on offline machines and aborts the installer.
Tasks
- Remove
Call ensureVCRedistandFunction ensureVCRedistfrominstaller/installer.nsi. - Remove
DownloadAndInstallVCRedistmacro frominstaller/macros.nsh. - Clean up associated localized strings in
installer/locale/*.nsh(DOWNLOAD_VCREDIST_*,INST_VCREDIST_*).
- Dominant language
- C++
- Stars
- 1.5k
- Forks
- 244
- Avg merge
- 19h 59m
- Merged PRs (30d)
- 33
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from EasyIME/PIME
-
添加"麼"輕聲 注音˙ㄇㄜ 順序1Openchewing enhancement upstream
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
"麼" 建議加上 ai7Open
Difficulty 1/5 Under an hour Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
蝦米輸入法,使用 Ctrl + / 問題Open
Difficulty 2/5 1-3 hours Newbie friendliness 60/100
EasyIME/PIME#753 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
Maintainers usually reply within 1 day
-
Candidate and message windows do not adapt to Per-Monitor High DPIPossibly taken @PCMan claimed this 2 days ago. Open
Difficulty 4/5 3-5 days Newbie friendliness 25/100
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
ROCm/rocm-libraries#14027 ·
Maintainers usually reply within 2 days
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
Qiskit/qiskit-aer#2487 ·
Maintainers usually reply within 1 day
-
GUI
Difficulty 1/5 Under an hour Newbie friendliness 78/100
qbittorrent/qBittorrent#25104 ·
Maintainers usually reply within 2 days
-
P2: A timed rotation maneuver does nothing on a ship that had an earlier timed lateral maneuverOpen
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
scp-fs2open/fs2open.github.com#7914 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 2 days