RMAX Error Printing (But Still Successful)
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 58/100
Research direction
Start in visualCaseGen/custom_widget_types/runoff_mapping_generator.py at RunoffMappingGenerator.on_btn_generate_new_clicked, especially line 165, and trace get_suggested_smoothing_params. Reproduce the successful 20 km run and inspect why suggested_rmax becomes 5000.0; done means the successful operation no longer prints the ROF_OCN_MAPPING_RMAX constraint error.
Written by the indexing model from the issue text.
Description
There is a rmax error printed even when I specified it to 20 km and it successfully run:
ile /glade/work/manishrv/installs/cesm3_0_beta08_gui/visualCaseGen/visualCaseGen/custom_widget_types/runoff_mapping_generator.py:165, in RunoffMappingGenerator.on_btn_generate_new_clicked(self, b)
162 _, ocn_mesh_path = self.get_ocn_grid_and_mesh()
163 suggested_rmax, suggested_fold = mapping.get_suggested_smoothing_params(ocn_mesh_path)
--> [165](https://vscode-remote+ssh-002dremote-002bcasper-002ehpc-002eucar-002eedu.vscode-resource.vscode-cdn.net/glade/work/manishrv/installs/cesm3_0_beta08_gui/visualCaseGen/visualCaseGen/custom_widget_types/runoff_mapping_generator.py:165) cvars["ROF_OCN_MAPPING_RMAX"].value = suggested_rmax
166 cvars["ROF_OCN_MAPPING_FOLD"].value = suggested_fold
File /glade/work/manishrv/conda-envs/vcg_gui/lib/python3.12/site-packages/traitlets/traitlets.py:735, in TraitType.__set__(self, obj, value)
733 if self.read_only:
734 raise TraitError('The "%s" trait is read-only.' % self.name)
--> [735](https://vscode-remote+ssh-002dremote-002bcasper-002ehpc-002eucar-002eedu.vscode-resource.vscode-cdn.net/glade/work/manishrv/conda-envs/vcg_gui/lib/python3.12/site-packages/traitlets/traitlets.py:735) self.set(obj, value)
File /glade/work/manishrv/conda-envs/vcg_gui/lib/python3.12/site-packages/traitlets/traitlets.py:709, in TraitType.set(self, obj, value)
708 def set(self, obj: HasTraits, value: S) -> None:
--> [709](https://vscode-remote+ssh-002dremote-002bcasper-002ehpc-002eucar-002eedu.vscode-resource.vscode-cdn.net/glade/work/manishrv/conda-envs/vcg_gui/lib/python3.12/site-packages/traitlets/traitlets.py:709) new_value = self._validate(obj, value)
710 assert self.name is not None
711 try:
...
352 # with the new assignment assertion when the new options_spec are called and they themselves call
353 # csp methods, e.g., check_assignments, that rely on self._assignment_assertions.
354 self._assignment_assertions.pop(var, None)
ConstraintViolation: Invalid assignment of ROF_OCN_MAPPING_RMAX to 5000.0. Reason: ROF_OCN_MAPPING_RMAX must be less than or equal to 4000 km.
- Dominant language
- Python
- Stars
- 16
- Forks
- 4
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 3
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ESMCI/visualCaseGen
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
ESMCI/visualCaseGen#43 ·
-
Miscellaneous pre-existing issues found while reviewing #45May be free again @manishvenu claimed this 29 days ago, and no pull request is open. Open
ESMCI/visualCaseGen#47 · 1 assignee ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
ESMCI/visualCaseGen#40 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
ESMCI/visualCaseGen#33 ·
-
question
Difficulty 2/5 1-3 hours Newbie friendliness 38/100
ESMCI/visualCaseGen#25 · 1 comment ·
All issues in ESMCI/visualCaseGen
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
awslabs/visual-asset-management-system#414 ·
Maintainers usually reply within 1 day
-
bug v1 v2
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
modelcontextprotocol/python-sdk#3670 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
aicell-lab/bioengine#232 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
modelscope/evalscope#1836 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100