flux and state data structure organization
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 20/100
- Issue type
- Refactor
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- fortran
- Domain
- backend
Research direction
No files or tests are named. Start by locating route_opt, STRFLX, and KREACH, then trace how routing schemes are selected and how flux and state data are shared. Done means the routing organization supports one scheme per simulation, with shared flux data and separate state structures for schemes as appropriate.
Written by the indexing model from the issue text.
Description
It is proposed that one routing scheme is used for one simulation (i.e., remove route_opt = 0, route with all the schemes), because as new routing schemes are added, using all the schemes at the same run is not practical.
With this in mind, there might be need for re-organization of flux data structure (STRFLX) and state data structures (KREACH for kinematic wave).
Suggestion
For Flux, the same data structure is shared with different routing schemes
e.g.,
TYPE, public :: STRFLX
real(dp) :: BASIN_QI ! instantaneous runoff volume from the local basin (m3/s)
real(dp) :: BASIN_QR(0:1) ! routed runoff volume from the local basin (m3/s)
real(dp) :: REACH_Q ! time-step average streamflow (m3/s)
real(dp) :: UPSTREAM_QI ! sum of upstream streamflow (m3/s)
real(dp) :: TAKE ! average take
logical(lgt) :: CHECK_ROUTE ! .true. if the reach is routed
END TYPE STRFLX
For states, each scheme has different state variable. so separate, unique data structure needs to be defined.
- Dominant language
- Fortran
- Stars
- 62
- Forks
- 73
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 4
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ESCOMP/mizuRoute
-
bug cesm-coupling cleanup
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
-
cesm-coupling enhancement infrastructure no answer change standalone
Difficulty 4/5 3-5 days Newbie friendliness 52/100
-
enhancement new features SUMMA coupling
Difficulty 5/5 Over a week Newbie friendliness 35/100
-
enhancement infrastructure SUMMA coupling
Difficulty 4/5 3-5 days Newbie friendliness 48/100
-
infrastructure SUMMA coupling
Difficulty 5/5 Over a week Newbie friendliness 32/100
All issues in ESCOMP/mizuRoute
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
`contacts.create` posts to `/audiences/undefined/contacts` when `audienceId` is undefinedPossibly taken @RaphaelFakhri claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
resend/resend-node#1176 ·
Maintainers usually reply within 1 day
-
EntitlementInfo.originalPurchaseDate returns the latest purchase date for subscriptionsPossibly taken @RaphaelFakhri claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
RevenueCat/purchases-js#1295 ·
Maintainers usually reply within 1 day
-
2022 2023 AR
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
PolicyEngine/policyengine-taxsim#1506 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
DiamondLightSource/fastcs#443 ·