Bug in 10cm Reflectivity Calculation.
@Katetc is already working on this.
Since Jul 13, 2022.
Assessment
This issue has not been assessed yet.
Description
The 10cm reflectivity calculation recently introduced in PUMAS is calculating infinity at some locations when used with micro_mg_do_hail = .true.
This is due to a bug in the logic of the conditional to trap for this which currently only works with graupel.
The bug is here in this line
https://github.com/ESCOMP/PUMAS/blob/pumas_cam-release_v1.26/micro_pumas_v1.F90#L4286
if (do_hail .or. do_graupel .and. lamg(i,k) > 0._r8) then
should be:
if ((do_hail .or. do_graupel) .and. lamg(i,k) > 0._r8) then
I'll need some help in adding this to the next PUMAS tag and making a PR. Should be quick. One line change. Thanks!
- Dominant language
- Fortran
- Stars
- 11
- Forks
- 24
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ESCOMP/PUMAS
-
Small bugOpen
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
-
Integrate TAU Microphysics EmulatorMay be free again @nusbaume claimed this 384 days ago, and no pull request is open. Open
-
Difficulty 2/5 1-3 hours Newbie friendliness 35/100