Test suite does not compare any h.bgc streams
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 28/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- xml
- Domain
- testing
Research direction
Read config_archive.xml and issues #323, #356, and #355 to understand the filename matching and related test coverage. The proposed fix is being added to #355, so this issue’s work is already under way; done would mean mom6.h.bgc.z streams are included in baseline comparisons.
Written by the indexing model from the issue text.
Description
#323 pointed out that mom6.h.bgc.native was ignored in baseline comparisons, and only mom6.h.bgc.z was tested. A bug in config_archive.xml combines with #356 to result in mom6.h.bgc.z being omitted in testing as well. A fix (that will compare a single block of mom6.h.bgc.z given #356) is
<!-- match filenames of the form
- h.bgc.*[._optional instance number].nc -->
- <hist_file_extension>h\.bgc\..*(\._\d+)?\.nc$</hist_file_extension>
+ h.bgc.*[._optional instance number].nc[.optional tile number] -->
+ <hist_file_extension>h\.bgc\..*(\._\d+)?\.nc(\.\d*)?(\.gz)?$</hist_file_extension>
I'm going to add this fix to #355 -- it's not strictly related to the MARBL diagnostics for CMIP, but is necessary for getting at least some test coverage so it seems fitting.
- Dominant language
- Jupyter Notebook
- Stars
- 6
- Forks
- 25
- Avg merge
- 12d 2h
- Merged PRs (30d)
- 1
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ESCOMP/MOM_interface
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
ESCOMP/MOM_interface#356 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 42/100
ESCOMP/MOM_interface#352 · 1 comment ·
-
Default value for ATM_ALT_CO2_OPT should be constMay be free again @mnlevy1981 claimed this 30 days ago, and no pull request is open. Open
ESCOMP/MOM_interface#351 · 1 comment · 1 assignee ·
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
ESCOMP/MOM_interface#323 ·
-
Error for missing INPUT filesMay be free again @alperaltuntas claimed this 208 days ago, and no pull request is open. Open
ESCOMP/MOM_interface#317 · 1 assignee ·
All issues in ESCOMP/MOM_interface
Similar issues
-
Test failure on FreeBSD: #26 unexpected system_clock sourcePossibly taken A pull request linked to this issue is open or already merged. Openlow priority rt_lib tests
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
prime-radiant-inc/evener#5028 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100