Have ability to exercise biofuels

Open
#4,151 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Quiet
Tech stack
fortran
Domain
data, testing

Research direction

Start in pftconMod.F90 by tracing mergetoclmpft and is_pft_known_to_model, then review the parameter-file behavior described in the issue. Add the named test surface dataset and parameter file, exercise them in testing, and verify completion with longer simulations, tuned parameters, and the CMIP7 future scenarios.

Written by the indexing model from the issue text.

Description

enhancement science size: small testing

Biofuels are needed for the CMIP7 future scenarios. In order to turn them on, we need datasets that have them, as well as a parameter file that doesn't collapse them to tropical corn. Biofuels have been in the code, but we haven't been exercising it. So there may be issues with getting it work, as well as tuning it in CMIP7.

Talked about biofuels needed for future scenarios. Will need to add a namelist item or change to the parameter file that doesn't collapse it to tropical corn. And add datasets and testing for it. I'll make an issue for this.

I looked at the code a bit to remind myself what may need changing. In pftconMod.F90 I see two relevant variables:

mergetoclmpft
is_pft_known_to_model

The latter seems to be derived from the former, which is set in the paramfile. We can look more carefully when it's time to work on this.

Originally posted by @slevis-lmwg in https://github.com/ESCOMP/CTSM/discussions/2206#discussioncomment-17910502

Definition of done:

  • Add a test surface dataset and parameter file that can be used to exercise it
  • Add the test in and get it to work
  • Run longer simulations to make sure it's working correctly
  • Tune any parameters as needed
  • Bring in the future scenarios for CMIP7 where this will be turned on by default
Dominant language
Fortran
Stars
362
Forks
372
Avg merge
1d 11h
Merged PRs (30d)
9

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ESCOMP/CTSM

All issues in ESCOMP/CTSM

Similar issues

More Data Engineering issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.