ocph/bcph fields in coupler and history output are unlabeled
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 35/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- fortran
- Domain
- backend
Research direction
Start by tracing the four black and organic carbon fields through the mediator and history output, then compare their ordering with CAM and downstream components. The issue proposes sending indices or descriptors from CAM so history fields can be labeled and downstream components can check the expected order; done means the field identities are explicit and order changes cannot silently produce incorrect results.
Written by the indexing model from the issue text.
Description
There are four fields passed to and from the mediator for black and organic carbon. The matrix of hydrophobic vs hydrophilic and wet vs dry deposition. They are unlabeled in the code and on history files, which makes it hard to know if you are indexing them correctly.
The only way to check is to look at what the order is in CAM and make sure that order is handled the same way downstream.
This suggests to me that CAM should send indices and/or descriptors to the driver. Then they could be labeled on history files and downstream components could ensure they are using the right order.
As it is the order is assumed and as long as it stays the same that's ok. But if CAM or another ATM changed the order it would silently be wrong in all downstream components. We haven't changed the order and seems unlikely we would but silently doing the wrong thing is an insidious problem.
- Dominant language
- Fortran
- Stars
- 36
- Forks
- 107
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 1
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ESCOMP/CMEPS
-
Latent heat bug in COARE atm/ocn flux routine for CESMMay be free again A pull request for this issue was closed without being merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 68/100
-
Add Sa_o3 to output CPLHIST daily average filesPossibly taken @ekluzek claimed this 7 days ago. OpenCESM only enhancement Responsibility: CTSM
-
Missing ablation: CISM melts less ice than CTSM doesPossibly taken @Katetc claimed this 9 days ago. Open
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
Maintainers usually reply within 1 day
-
bug priority: high workstream:cache
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
rossoctl/context-guru#707 ·
Maintainers usually reply within 1 day
-
api bug entity mobai
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Pumpkin-MC/Pumpkin#4312 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
backdrop-contrib/paragraphs#299 ·