Add some tests to the aux_cdeps test list to cover modes that currently aren't tested

Open
  • Is something wrong?
#381 4 comments 0 reactions 2 assignees View on GitHub

@mvertens is already working on this.

Since Jan 23, 2026.

Assessment

This issue has not been assessed yet.

Description

In connection with the investigation of test coverage for #376 , I talked with @mvertens about what testing we might want to add to the aux_cdeps test list. Here is a list of data model modes that aren't currently covered in aux_cdeps testing and I think should be. (This covers most of the data model modes, but I may have left out some that have nearly similar or identical code paths to already-covered modes.)

DATM:

  • CPLHIST
  • JRA-RYF* - some version of this
  • A test that sets DATM_PRESO3 to true via a testmod (by default this is turned off for compsets with SLND or DLND)
  • A test that turns on bias-correction via a testmod (e.g., see the testmod used for SMS_Ld1_PS.f09_g17.I2000Clm50BgcCru.derecho_gnu.clm-datm_bias_correct_cruv7)
  • A test that turns on anomaly forcing via a testmod (e.g., see the testmod used for SMS_D_Ld5.f10_f10_mg37.ISSP245Clm60BgcCropCrujra.derecho_intel.clm-datm_rcp45_anom_forc)

DLND:

  • GCPL (we currently test SCPL but not the newer GCPL)
  • RCPL

DOCN:

  • DOCN%AQP3 (to get coverage of sst_aquap_analytic... this also covers most of the code for ssp_aquap_constant)
  • Do we want a test of DOCN%SOM? I think I remember @mvertens saying that this needs an active component to work? We do have a test of DOCN%SOMAQP (SMS_Ln5.f19_f19_mg17.2000_DATM%QIA_SLND_SICE_DOCN%SOMAQP_SROF_SGLC_SWAV.derecho_intel), and this covers nearly all of the code of DOCN%SOM
  • Ideally we'd include testing of DOCN%MULTILEV, DOCN%MULTILEV-CPLHIST and DOCN%MULTILEV-DOM, but these aren't currently available in CESM; @mvertens - can they be tested in NorESM?

DROF:

  • JRA
  • CPLHIST

@mvertens - if you have time for this, it would be great to chat more at some point and jointly come up with reasonable tests that we can add to the aux_cdeps test list: I'd be interested in hearing any thoughts you have on my list or anything else you feel should be added. No rush, though. (I'm assigning both of us to this, but if you don't have time for it, you can remove yourself.)

Dominant language
Fortran
Stars
32
Forks
71
Avg merge
1d 6h
Merged PRs (30d)
2

Getting set up

  • No Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ESCOMP/CDEPS

All issues in ESCOMP/CDEPS

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.