Remove for_testing_allow_non_annual_changes from user_nl_clm
Maintainers usually reply within 4 days
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 25/100
- Issue type
- Refactor
- Clarity
- Clearly specified
- Activity status
- Stale
- Domain
- testing
Research direction
Find the outfrq9s_leapday testmod and its user_nl_clm setting; the issue does not name a file path. Read the open pull request #1738 and check whether it already handles this cleanup. Done means the setting is removed without changing meaningful behavior, and relevant tests still pass.
Written by the indexing model from the issue text.
Description
Issue Type
Code Clean-up
Issue Description
The outfrq9s_leapday testmod sets for_testing_allow_non_annual_changes in user_nl_clm. This was added by @kdraeder to allow an ERI test to pass with this testmod.
With the changes in https://github.com/ESCOMP/CTSM/pull/4281, I believe this setting will no longer be needed. It would probably be safe to remove it before that CTSM version is pulled into CAM because I don't think there are currently any ERI tests using the outfrq9s_leapday testmod in any standard test lists - though it might break any additional testing that @kdraeder is doing.
Removing this setting won't change behavior in any meaningful way; this setting just bypassed some error checks that should no longer need to be bypassed. I prefer removing this setting so that we're not unnecessarily bypassing error checks.
Will this change answers?
No
Will you be implementing this yourself?
Yes
- Dominant language
- No language data
- Stars
- 93
- Forks
- 186
- Avg merge
- 4d 21h
- Merged PRs (30d)
- 18
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ESCOMP/CAM
-
build-namelist hangs (infinite loop) on #-commented line in user_nl_camPossibly taken @jtruesdal claimed this 20 days ago. Openbug misc tag Must have CESM3
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
ESCOMP/CAM#1701 · 2 comments · 1 assignee ·
Maintainers usually reply within 4 days
-
CoupledEval3 Must have CESM3
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 4 days
-
after CESM3_0 enhancement
Difficulty 4/5 3-5 days Newbie friendliness 45/100
Maintainers usually reply within 4 days
-
Bring in upcoming PUMAS bug fixes (ESCOMP/PUMAS#81); answer-changing for CAM7 defaultsPossibly taken @peverwhee claimed this 6 days ago. Openbug Must have CESM3
Difficulty 5/5 Over a week Newbie friendliness 25/100
ESCOMP/CAM#1732 · 2 assignees ·
Maintainers usually reply within 4 days
-
MPAS dycore timer resets for restart runsPossibly taken @nusbaume claimed this 6 days ago. Openbug
Difficulty 4/5 3-5 days Newbie friendliness 35/100
ESCOMP/CAM#1721 · 1 comment · 1 assignee ·
Maintainers usually reply within 4 days
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
sylvainmetayer/homelab#851 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 1 day
-
is:bug is:FQNIssue
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
nunit/nunit3-vs-adapter#1527 ·
Maintainers usually reply within 1 day
-
enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
jainam6610/calm-ui#8 ·
Maintainers usually reply within 1 day