MULTILEADER gaps

Open
#980 2 comments 1 reaction 0 assignees View on GitHub

Maintainers usually reply within 3 days

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp

Research direction

Start by reading the scene-graph MULTILEADER path and the context data and model fields named in the issue. Choose one of the listed gaps, then check how the existing corner-case tests cover it. Done means implementing that gap and adding regression coverage; oracle-based fixtures are needed for the parity work.

Written by the indexing model from the issue text.

Description

ACadSharp MULTILEADER Gaps

  • DXF reader now captures MULTILEADER line/dogleg breaks in context data:

    • LeaderLine.StartEndPoints + LeaderLine.SegmentIndex
    • LeaderRoot.BreakStartEndPointsPairs
  • Renderer avoids orphan doglegs when no visible leader line was produced for a root.

  • Test coverage expanded for MULTILEADER corner cases (dogleg disabled endpoint, invisible line behavior, dogleg breaks, multiple roots, direction fallback, custom arrow block, DXF break parsing path).

  • Render-plane fields from context data are not applied:

    • BasePoint, BaseDirection, BaseVertical, NormalReversed
    • Current behavior assumes WCS-only geometry.
  • Connection semantics are simplified:

    • LandingGap is not used to reposition content.
    • Block/text connection-to-extents logic is not implemented (mostly trusts parsed content locations).
  • MTEXT extras from context data are not mapped in rendering:

    • text background fill/mask settings
    • text columns and related layout flags
  • Annotative context selection is not implemented (render path uses MultiLeader.ContextData directly).

  • Break representation in ACadSharp model is limited:

    • LeaderLine has one SegmentIndex for all break pairs, so breaks on multiple segments of the same line cannot be represented faithfully.
  • Cross-CAD parity for connection types is incomplete:

    • per-side behavior (left/right/top/bottom variants, underline/overline modes) is not modeled as a first-class render strategy.
  • Color handling needs oracle validation for all raw-color edge cases (ByBlock, ByLayer, true-color variants in MULTILEADER-specific fields).

Open gaps (validation and quality)

  • Need more oracle tests with real files (AutoCAD/TrueView/BricsCAD baselines):
    • mixed MTEXT/BLOCK content variants
    • multi-root + multi-line + mixed break patterns
    • vertical-attachment cases
    • non-default context plane orientation
  • Need explicit regression fixtures for DXF vs DWG parity around breaks and style overrides.

Suggested next implementation order

  1. Apply context render-plane transformation (BasePoint/BaseDirection/BaseVertical/NormalReversed) in scene-graph MULTILEADER path.
  2. Implement LandingGap + connection-to-content semantics for text/block anchors.
  3. Add MTEXT background/column mapping for MLEADER content.
  4. Extend model or parser strategy for multi-segment break encoding in one leader line.
  5. Add oracle-based integration fixtures for parity verification.
Dominant language
C#
Stars
873
Forks
223
Avg merge
1d 15h
Merged PRs (30d)
28

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from DomCR/ACadSharp

All issues in DomCR/ACadSharp

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.