Generated stand-in crates extern crate lines trip unused_extern_crates

Open
#25 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
65/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
rust
Domain
build-system

Research direction

Find the rustd code that emits the stand-in crate's extern crate declarations (the generator for target/debug/.rustd-units/*.rustd.rs). Add #[allow(unused_extern_crates)] to those lines or invoke rustc with --cap-lints allow for generated code. Confirm by running the reth build command from the issue and checking the unused extern crate errors disappear.

Written by the indexing model from the issue text.

Description

Environment: bare-metal x86-64, 48 cores, 377 GB RAM, Ubuntu 24.04, Rust 1.99.0 with rust-src, rustd nightly release 4530fb8 from install.sh (RUSTD_VERSION=nightly).

git clone https://github.com/paradigmxyz/reth && cd reth && git checkout f90ed27
echo 1.99.0 > rust-toolchain
F="--bin reth --no-default-features --features jemalloc,otlp,otlp-logs,js-tracer,keccak-cache-global,asm-keccak,gmp,min-trace-logs,portable"  # no jit: evm2-jit-llvm needs llvm-config 23
cargo rustd build $F

Expected: rustd builds reth. Plain cargo builds it in 97 s.

Actual: it fails in under 3 s on the first workspace crate:

error: rustd does not build `reth_fs_util`: what stands in for it does not build:
error: unused extern crate
 --> target/debug/.rustd-units/reth_fs_util-bbff10c55562cefb/…/reth_fs_util-bbff10c55562cefb.rustd.rs:2:1
2 | extern crate serde;
error: unused extern crate
 --> …rustd.rs:4:1
4 | extern crate thiserror;
error: could not compile `reth-fs-util` (lib) due to 2 previous errors

The stand-in crate declares an extern crate for each dependency and uses none of them, and reth's lint settings turn unused_extern_crates into an error. Same root cause as the global_asm! / forbid(unsafe_code) failure: generated code shouldn't be built with the workspace's lints (--cap-lints allow, or #[allow(unused_extern_crates)] on those lines).

Dominant language
Rust
Stars
248
Forks
13
Avg merge
7h 52m
Merged PRs (30d)
5

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from DioxusLabs/rustd

All issues in DioxusLabs/rustd

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.