Workflows cli create cmd issues
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
Research direction
Start by tracing the workflows create command into generate_template_repo and copy_directory; inspect the fs::read_dir(src) calls and the handling of workflow_home/template-boilerplate/conventional-templates and helm-based-templates. Verify missing sources and copy failures propagate, YAML input is not made into a directory, and prerequisite checks happen before prompting.
Written by the indexing model from the issue text.
Description
Got 4 bugs:
1- Treating a YAML file as a directory name
eg: workflows create hello_cli_test.yaml
the program creates a directory named : hello_cli_test.yaml
2- Missing source directories are NOT treated as errors
It is assumed that these are always present :
workflow_home/template-boilerplate/conventional-templates
workflow_home/template-boilerplate/helm-based-templates
But in the instuled model they dont exist: fs::read_dir(src)
3- Errors are swallowed instead of propagated
The copy_directory function, prints ERRORS, returns, and Never signal a failure
generate_template_repo always returns Ok(())
4- User is prompted before prerequisites are validated
eg: ould you like to store conventional WorkflowTemplate manifests? Y
Operation cannot possibly succeed because there is no template, so it should check before asking.
- Dominant language
- Rust
- Stars
- 7
- Forks
- 6
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 56
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from DiamondLightSource/workflows
-
workflows lint-config always fails on ClusterTriggerTemplate manifests ("found nothing to lint") Open
Difficulty 3/5 1-2 days Newbie friendliness 58/100
DiamondLightSource/workflows#1612 · 2 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
DiamondLightSource/workflows#587 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
DiamondLightSource/workflows#585 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
DiamondLightSource/workflows#551 ·
-
rust
Difficulty 4/5 3-5 days Newbie friendliness 35/100
DiamondLightSource/workflows#404 ·
All issues in DiamondLightSource/workflows
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Eynzof/Hermes-CN-Desktop#610 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
gitbutlerapp/gitbutler#15998 · 1 comment ·
-
bug triage:deciding
Difficulty 1/5 Under an hour Newbie friendliness 88/100
open-telemetry/otel-arrow#4132 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100