Spacing at the top of SidebarNav should be configurable
Maintainers usually reply within 2 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 65/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- typescript
- Domain
- frontend
Research direction
Start by locating the SidebarNav component and its existing empty Toolbar spacer, then inspect how its component API and footer slot are structured. The change is done when the top and bottom spacing can be configured for layouts using components other than MUI's AppBar, without obscuring the footer slot.
Written by the indexing model from the issue text.
Description
Change Proposal: Configurable space at the top and bottom of SidebarNav
SidebarNav was originally created to sit under MUI's AppBar, which uses a Toolbar. Following MUI's own guidance, SidebarNav used an empty Toolbar at the top of the component for perfect alignment with the content in the main section. When some other component is used instead of AppBar e.g. our own NavBar, the space created by Toolbar doesn't match what we want. That space should be configurable. The same is true for a bottom spacer, so that the footer slot is not obscured by a potential status bar.
- Dominant language
- TypeScript
- Stars
- 9
- Forks
- 3
- Avg merge
- 6d 7h
- Merged PRs (30d)
- 20
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from DiamondLightSource/sci-react-ui
-
needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
DiamondLightSource/sci-react-ui#325 · 1 comment ·
Maintainers usually reply within 2 days
-
accepted
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
DiamondLightSource/sci-react-ui#283 ·
Maintainers usually reply within 2 days
-
needs-triage
Difficulty 5/5 Over a week Newbie friendliness 38/100
DiamondLightSource/sci-react-ui#332 ·
Maintainers usually reply within 2 days
-
needs-triage
Difficulty 5/5 Over a week Newbie friendliness 35/100
DiamondLightSource/sci-react-ui#331 ·
Maintainers usually reply within 2 days
-
needs-triage
Difficulty 4/5 3-5 days Newbie friendliness 55/100
DiamondLightSource/sci-react-ui#324 ·
Maintainers usually reply within 2 days
All issues in DiamondLightSource/sci-react-ui
Similar issues
-
enhancement providers-api ui-dashboard
Difficulty 2/5 1-3 hours Newbie friendliness 61/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
external-issue to-triage
Difficulty 1/5 Under an hour Newbie friendliness 90/100
Maintainers usually reply within 1 day
-
needs triage
Difficulty 1/5 Under an hour Newbie friendliness 88/100
homarr-labs/homarr#6976 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day