Pascal case instance attribute in `UiLayer`

Open
#589 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
58/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Stale
Tech stack
python
Domain
backend

Research direction

Open httomo/ui_layer.py at line 48 and inspect the PascalCase instance attribute and its surrounding uses. Search the repository for references to the old attribute name, rename them to self.pipeline_stage_config, and confirm no old references remain.

Written by the indexing model from the issue text.

Description

minor

There's an instance attribute of UiLayer which is pascal case: https://github.com/DiamondLightSource/httomo/blob/c7e399d09f56a238e4c731c5f66857047f7f4752/httomo/ui_layer.py#L48

In python it's convention that instance attributes (among other things) are snake case, and that pascal case is reserved for classes.

Therefore, I think this is better named as self.pipeline_stage_config.

Dominant language
Python
Stars
10
Forks
5
Avg merge
5d 17h
Merged PRs (30d)
1

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from DiamondLightSource/httomo

All issues in DiamondLightSource/httomo

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.