Some framework tests require tomopy
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 30/100
Research direction
Start by locating the four named tests: test_pipeline_build_duplicate_id, test_pipeline_build_cpu_pipeline, test_build_pipeline_with_param_sweeps, and its duplicate listing. Trace why these UI-layer tests require tomopy and how they are included in the framework-test classification. Done means either the framework tests no longer require tomopy or the UI tests are consistently excluded from that classification.
Written by the indexing model from the issue text.
Description
In work on trying to reduce the usage of conda packages in httomo installation (#564) it was discovered that there are four UI layer tests that are part of what is currently classified as "framework" tests, that require tomopy to be installed to be able to run:
test_pipeline_build_duplicate_id
test_pipeline_build_cpu_pipeline
test_build_pipeline_with_param_sweeps
test_build_pipeline_with_param_sweeps
It may be worth either:
- trying to remove the dependency on tomopy in framework tests
- or, rethink the classification of what is part of the framework and what isn't (ie, the UI layer is one of the outermost layers of httomo, it could therefore be argued that it's not part of the core framework, and thus it may be fine for the UI layer to depend on tomopy - but in this case, it may then make sense to exclude the UI layer tests from the "framework" tests)
- Dominant language
- Python
- Stars
- 10
- Forks
- 5
- Avg merge
- 5d 17h
- Merged PRs (30d)
- 1
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from DiamondLightSource/httomo
-
ci
Difficulty 1/5 Under an hour Newbie friendliness 88/100
DiamondLightSource/httomo#714 ·
-
framework minor
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
DiamondLightSource/httomo#699 ·
-
documentation question
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
DiamondLightSource/httomo#697 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
DiamondLightSource/httomo#609 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
DiamondLightSource/httomo#607 ·
All issues in DiamondLightSource/httomo
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100