Fix small typo/misleading var name in wrapper output dims calculator test
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 68/100
- Issue type
- Refactor
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- python
- Domain
- testing-qa
Research direction
Open tests/method_wrappers/test_generic.py and inspect test_generic_calculate_output_dims, especially the patched calculate_output_dims() call around lines 600–602. Rename the misleading memcalc_mock variable to a name matching the output-dimensions calculator, then run the relevant test to confirm it still passes.
Written by the indexing model from the issue text.
Description
The calculation of the output dims is being tested in this particular test called test_generic_calculate_output_dims.
During the test, the calculate_output_dims() method on a query object is patched: https://github.com/DiamondLightSource/httomo/blob/f7f4d96508b5e757a42f22bc10e93bec319854a9/tests/method_wrappers/test_generic.py#L600-L602
However, the name of the variable memcalc_mock suggests that the method on the query object being patched is the memory calculator method (ie, calculate_max_slices()), which isn't the case.
This variable name is likely a typo, but is misleading, so should be changed to something like output_dims_calc_mock to avoid confusion.
- Dominant language
- Python
- Stars
- 10
- Forks
- 5
- Avg merge
- 5d 17h
- Merged PRs (30d)
- 1
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from DiamondLightSource/httomo
-
ci
Difficulty 1/5 Under an hour Newbie friendliness 88/100
DiamondLightSource/httomo#714 ·
-
framework minor
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
DiamondLightSource/httomo#699 ·
-
documentation question
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
DiamondLightSource/httomo#697 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
DiamondLightSource/httomo#609 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
DiamondLightSource/httomo#607 ·
All issues in DiamondLightSource/httomo
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100