[Bug] Removing invalid profession followed by Added profession over and over

Open
#141 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
Half a day
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
lua
Domain
game-dev

Research direction

The log lines "Removing invalid profession" and "Added profession" are the starting point, so search the Lua sources for those strings to find the profession-validation and add logic. Reproduce by opening and closing a profession UI on a low-level character and check whether the same two profession names are removed and re-added each time. Done means the pair stops cycling across repeated UI opens while Darkmoon Faire profession tracking still works.

Written by the indexing model from the issue text.

Description

Bug
Addon version

v1.2.6

Tested with only this addon enabled?

No

Describe what happened and what you expected to happen

On some of my low level toons I'm seeing this pattern repeat multiple times per session. I'm doing the Darkmoon Faire profession quests.

[09:33:40] WeeklyKnowledge: Removing invalid profession: Dragon Isles Alchemy
[09:33:40] WeeklyKnowledge: Removing invalid profession: Dragon Isles Herbalism
[09:33:40] WeeklyKnowledge: Added profession: Dragon Isles Alchemy
[09:33:40] WeeklyKnowledge: Added profession: Dragon Isles Herbalism
Steps to reproduce

Opening and closing any profession UI causes this to occur.

Lua error(s)

Screenshots

No response

Dominant language
Lua
Stars
15
Forks
15
PR merge metrics
No merged PRs in 30d

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from DennisRas/WeeklyKnowledge

All issues in DennisRas/WeeklyKnowledge

Similar issues

More Lua issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.