Align refinement on gridded/nongridded samples
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 38/100
Research direction
Start at meshkernel.MeshRefinementParameters() and mesh2d_refine_based_on_gridded_samples(), then trace how xyz and gridded samples are interpolated before refinement. Compare the existing face- and node-based paths, including landsea handling; done means both sample formats produce aligned refinement behavior near coastlines and away from them.
Written by the indexing model from the issue text.
Description
Is your feature request related to a problem? Please describe.
There is a discrepancy in the refinement method depending on the type of samples provided. Align this so similar outputs can be expected with similar data (in different formats)
Describe the solution you'd like
When refining on xyz samples, the samples are interpolated to faces and then the faces are refined based on the value. With gridded samples, the samples are interpolated to nodes and there are three options:
- all nodes of a cell on land (above 0): do not refine
- all nodes of a cell in water (below 0): normal refine
- some nodes of a cell in water and some on land: always refine until min_edge_size
Align these, so also interpolate xyz samples to nodes and include landsea feature. This will result in minor or no changes away from the coastline and improve the grid next to the coastline.
Describe alternatives you've considered
None
additional question
This might be related to use_mass_center_when_refining in meshkernel.MeshRefinementParameters() and use_nodal_refinement in mesh2d_refine_based_on_gridded_samples()
- Dominant language
- Python
- Stars
- 27
- Forks
- 5
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Deltares/MeshKernelPy
-
chore
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Deltares/MeshKernelPy#284 ·
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 65/100
Deltares/MeshKernelPy#279 · 1 comment ·
-
Add support for Python 3.14Possibly taken @veenstrajelmer claimed this 138 days ago. Openchore
Difficulty 3/5 1-2 days Newbie friendliness 25/100
Deltares/MeshKernelPy#251 · 2 comments ·
-
global grid from `mesh2d_make_global` does not always extend to the polesPossibly taken @BillSenior claimed this 51 days ago. Openbug
Difficulty 4/5 3-5 days Newbie friendliness 25/100
Deltares/MeshKernelPy#236 · 1 comment ·
-
chore
Difficulty 4/5 3-5 days Newbie friendliness 45/100
Deltares/MeshKernelPy#190 ·
All issues in Deltares/MeshKernelPy
Similar issues
-
Improve Task Cache Windows Registry events to carry the task subkey's last written time and key pathOpen
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
log2timeline/plaso#5299 · 1 comment ·
Maintainers usually reply within 2 days
-
deployment release-lag
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
nolte/kamerplanter#2047 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
ClanGenOfficial/clangen#6216 · 1 comment ·
Maintainers usually reply within 1 day
-
API bug connectors
Difficulty 2/5 1-3 hours Newbie friendliness 92/100
pyinfra-dev/pyinfra#1986 ·
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
521xueweihan/HelloGitHub#3847 ·