Four test assertions carried over from the C# suite are still commented out
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- python
- Domain
- testing-qa
Research direction
Start at tests/test_dfsu2D.py lines 404, 469, and 806, plus tests/test_dfs_static_item.py line 113. Add the three specified AxisUnit assertions, then determine whether the remaining TODO should become a real test or be removed. Run the affected test files and confirm the assertions pass and no commented TODO remains.
Written by the indexing model from the issue text.
Description
Four assertions carried over from the original C# test suite are still commented out:
tests/test_dfsu2D.py:404—# TODO: Assert.AreEqual(eumUnit.eumUmeter, axis.AxisUnit);tests/test_dfsu2D.py:469— sametests/test_dfsu2D.py:806—# TODO: Implement?tests/test_dfs_static_item.py:113—# TODO: Assert.AreEqual(eumUnit.eumUmeter, axis.AxisUnit
The three AxisUnit ones are a single, small check in Python:
assert axis.AxisUnit == eumUnit.eumUmeter
If that holds, the tests get slightly stronger for free. If it does not hold, that is more interesting than the test, and worth a separate issue.
test_dfsu2D.py:806 is vaguer and may just be a note that the C# original tested something the Python port does not cover; it should either become a real test or be removed.
Small, self-contained, and a reasonable first contribution.
- Dominant language
- Python
- Stars
- 5
- Forks
- 1
- Avg merge
- 13m
- Merged PRs (30d)
- 3
Getting set up
We have not checked this project's setup files yet. Start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from DHI/mikecore-python
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
DHI/mikecore-python#59 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
DHI/mikecore-python#54 · 2 comments ·
-
Difficulty 5/5 Over a week Newbie friendliness 45/100
DHI/mikecore-python#52 ·
-
Remaining TODOs in production code: platform notes, licensing questions, and one likely-stale markerOpen
Difficulty 5/5 Over a week Newbie friendliness 30/100
DHI/mikecore-python#51 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
DHI/mikecore-python#50 ·
All issues in DHI/mikecore-python
Similar issues
-
docs pydanty:is-working
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
pydantic/pydantic-ai#8863 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
run-llama/llama_index#23278 ·
Maintainers usually reply within 2 days
-
documentation from-review-extraction github-actions priority: low severity:nit
Difficulty 1/5 Under an hour Newbie friendliness 92/100
LearningCircuit/local-deep-research#6946 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
oracle/langchain-oracle#323 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
tenstorrent/tt-metal#58057 · 1 comment ·
Maintainers usually reply within 1 day