eum.py: ~120 lines of commented-out, half-translated EUM filter API stubs — port or delete
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 45/100
Research direction
Inspect the commented EUM filter/sequence block in mikecore/eum.py around lines 1904–2025 and the surrounding wrapped API to determine whether Python callers need filter enumeration. Done means either replacing the declarations with valid Python wrappers or removing the block, its nine TODOs, and documenting the unwrapped filter API in the module docstring.
Written by the indexing model from the issue text.
Description
mikecore/eum.py carries roughly 120 lines of commented-out, half-translated C# declarations — from about line 1904 to about line 2025 — each carrying a # TODO: Pending marker. Nine of the module's TODOs live inside them. They look like this:
# #/ <summary>
# #/ TODO: Pending
# #/ </summary>
# @staticmethod
# def eumGetFilterCount(); -> int:
#
# private static bool _eumGetFilterSeq(SeqNo: int, out FtKey: int, out IntPtr lpFtDesc);
They are not valid Python even uncommented — the signatures are a mix of Python and C# (def eumGetFilterCount(); -> int:, private static bool, out IntPtr), so they are a transcription of the original API surface rather than code that ever ran.
The affected group is the EUM filter/sequence family (eumGetFilterCount, eumGetFilterSeq, and neighbours).
Worth deciding once, either way:
- Port them, if anything needs to enumerate EUM filters from Python; or
- Delete them, and note in the module docstring that the filter API is not wrapped.
Either outcome removes nine TODOs and about 120 lines of noise from the largest module in the package. Leaving them is the only option that keeps implying work is planned when none is.
- Dominant language
- Python
- Stars
- 5
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from DHI/mikecore-python
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
DHI/mikecore-python#49 ·
-
Difficulty 5/5 Over a week Newbie friendliness 45/100
DHI/mikecore-python#52 ·
-
Remaining TODOs in production code: platform notes, licensing questions, and one likely-stale marker Open
Difficulty 5/5 Over a week Newbie friendliness 30/100
DHI/mikecore-python#51 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
DHI/mikecore-python#50 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
DHI/mikecore-python#47 ·
All issues in DHI/mikecore-python
Similar issues
-
documentation help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
simonw/sqlite-utils#872 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100