[Defect]: FFDH pattern treats ephemeral E as required
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 82/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- json
- Domain
- cryptography
Research direction
The fix is the pattern value for FFDH in schema/cryptography-defs.json. Compare it with the ECDH entry, which already uses ECDH[E][-{ellipticCurve}], and check the naming-pattern grammar it refers to. Change the FFDH pattern to FFDH[E][-{namedGroup}]. Done when FFDH, FFDHE and FFDHE-ffdhe2048 all validate against the pattern.
Written by the indexing model from the issue text.
Description
Describe the defect
schema/cryptography-defs.json currently has:
"pattern": "FFDH(E)[-{namedGroup}]"
Under the naming-pattern grammar (parentheses group; they are not optional), E is required, so constructed names can only be FFDHE / FFDHE-{namedGroup}. FFDH without E does not match.
ECDH already uses optional E: ECDH[E][-{ellipticCurve}]. FFDH should match that: E is ephemeral and optional
Expected
"pattern": "FFDH[E][-{namedGroup}]"
so FFDH, FFDHE, and FFDHE-ffdhe2048 are all valid.
- Dominant language
- XSLT
- Stars
- 558
- Forks
- 93
- Avg merge
- 19h 7m
- Merged PRs (30d)
- 17
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from CycloneDX/specification
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
CycloneDX/specification#1145 · 4 comments ·
Maintainers usually reply within 1 day
-
Response vs ResponceOpen
Difficulty 1/5 Under an hour Newbie friendliness 68/100
CycloneDX/specification#1121 · 1 comment ·
Maintainers usually reply within 1 day
-
defect documentation
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
CycloneDX/specification#1115 ·
Maintainers usually reply within 1 day
-
[FEATURE]: Add EAX mode to Cryptography RegistryPossibly taken @jvdsn claimed this 30 days ago. Opencap: cryptography-registry
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
CycloneDX/specification#1098 ·
Maintainers usually reply within 1 day
-
defect
Difficulty 1/5 Under an hour Newbie friendliness 91/100
CycloneDX/specification#1045 · 2 comments ·
Maintainers usually reply within 1 day
All issues in CycloneDX/specification
Similar issues
-
French BIP39 wordlist starts with a UTF-8 BOM, so generated French mnemonics carry U+FEFF and derive a non-canonical seedPossibly taken @Kshot3000 claimed this today. Open
Difficulty 1/5 Under an hour Newbie friendliness 91/100
ergoplatform/sigma-rust#976 ·
Maintainers usually reply within 1 day
-
init variableOpen
Difficulty 1/5 Under an hour Newbie friendliness 88/100
EVerest/EVerest#3052 · 1 reaction ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
status:untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
midnightntwrk/midnight-zk#558 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
indygreg/cryptography-rs#99 ·