The samples are all completely independent and self-contained.
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 35/100
- Issue type
- Documentation
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- php
- Domain
- documentation
Research direction
Start with the README section "Using the Sample Code" and the referenced Samples/Payments/Payments/AuthorizationWithCaptureSale.php file. Confirm what "independent" and "self-contained" are intended to mean, then update the wording to match the documented dependencies and verify the links and examples remain accurate.
Written by the indexing model from the issue text.
Description
Under Readme section "Using the Sample Code" - https://github.com/CyberSource/cybersource-rest-samples-php#using-the-sample-code - it states "The samples are all completely independent and self-contained.", but after reviewing the code, this doesn't appear to be true.
This file has code:
require_once __DIR__ . DIRECTORY_SEPARATOR . '../../../Resources/ExternalConfiguration.php';
which is another file in the repo. Maybe I'm reading the blurb wrong, but that file to me is a sample, and if it's self-contained it shouldn't require other files.
Anyway, even if I consider "self-contained" samples to mean "the repo is self-contained as a run app", then that's not exactly true either. The above line of code requires vendor through composer that's compatible with PHP 5.6:
require_once __DIR__ . DIRECTORY_SEPARATOR . '../../../vendor/autoload.php';
This is required for at least one line in that AuthorizationWithCaptureSale.php sample file's code, like:
$api_instance = new CyberSource\Api\PaymentsApi($api_client);
I'm working on a Mac (Ventura) that doesn't have PHP 5.6 or a compatible version of composer installed, so I will have to do a deep-dive to figure that out for a "self-contained" sample file.
Anyway, I can try to get the whole repo with vendor code running, but to me the blurb is not accurate, as the sample files are not self-contained. I'm curious exactly what's meant by "self-contained" or "independent".
- Dominant language
- JavaScript
- Stars
- 43
- Forks
- 66
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 1
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from CyberSource/cybersource-rest-samples-node
-
Difficulty 4/5 3-5 days Newbie friendliness 30/100
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
CyberSource/cybersource-rest-samples-node#72 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
CyberSource/cybersource-rest-samples-node#66 · 5 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 20/100
All issues in CyberSource/cybersource-rest-samples-node
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Spomky-Labs/pwa-bundle#476 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 69/100
c1overzz/dsh-bili-scroll#35 ·
Maintainers usually reply within 1 day
-
needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
pbakaus/impeccable#1077 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day