enableLog flag not working
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- observability-sre
Research direction
Start by tracing how enableLog is passed from the new API client configuration into the winston-daily-rotate-file transport, focusing on the transport's silent option. Confirm whether that option suppresses filesystem logging, then verify that enableLog: false prevents log files while the default or enabled setting still writes them.
Written by the indexing model from the issue text.
Description
Summary
The enableLog configuration option is disregarded and log files are generated even when the value is false.
Expected Behavior
Specifying enableLog: false when creating a new API client should suppress log files from being written to. An example would be as follows:
const cybersourceRestApi = require('cybersource-rest-client')
const merchantConfig = {
authenticationType: 'http_signature',
runEnvironment: 'cybersource.environment.SANDBOX',
merchantID: 'XXXXXXX',
merchantKeyId: 'XXXXXXXXX',
merchantsecretKey: 'XXXXXXXXXXXXXX',
enableLog: false // this should result in logs from the CyberSource REST client being suppressed
}
const paymentsApi = new cybersourceRestApi.PaymentsApi(merchantConfig)
Actual Behavior
When enableLog: false is specified, the CyberSource REST client still writes logs to the filesystem.
Other Comments
It looks like there was a switch to using the winston-daily-rotate-file package recently, and the enableLog option from the CyberSource client is being passed to this transport as part of a silent option. However, it looks like there is no reference to a silent option in the documentation for this package and so it may not be a valid option for this transport.
- Dominant language
- JavaScript
- Stars
- 50
- Forks
- 50
- Avg merge
- 19m
- Merged PRs (30d)
- 1
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from CyberSource/cybersource-rest-client-node
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative insteadOpen
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 52/100
CyberSource/cybersource-rest-client-node#173 · 1 reaction ·
-
Difficulty 3/5 Half a day Newbie friendliness 35/100
CyberSource/cybersource-rest-client-node#148 · 2 comments ·
All issues in CyberSource/cybersource-rest-client-node
Similar issues
-
automation models
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
needs:triage
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
enhancement status: needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
mastra-ai/mastra#25508 · 1 comment ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
agentic-workflows
Difficulty 1/5 Under an hour Newbie friendliness 72/100
githubnext/gh-aw-cao#15017 ·
Maintainers usually reply within 1 day