ApiClient.java leaks ResponseBody objects
@gnongsie is already working on this.
Since Jun 15, 2019.
Assessment
This issue has not been assessed yet.
Description
hello, if you don't call ResponseBody.close() on your ResponseBody objects you are leaking resources. I've just spent time in the debugger tracing a few runs of the sample DownloadReport.java from your samples repository. ApiClient is clearly not closing the ResponseBody. The only call to close() appears in ApiClient.handleResponse..and it is conditional: only runs if the HTTP status code is 204 (no content ironically). There is a reason ResponseBody implements Closeable. Sorry but no time to contribute code.
- Dominant language
- Java
- Stars
- 29
- Forks
- 50
- Avg merge
- 28m
- Merged PRs (30d)
- 1
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from CyberSource/cybersource-rest-client-java
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
CyberSource/cybersource-rest-client-java#241 · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 58/100
-
Difficulty 3/5 1-2 days Newbie friendliness 42/100
CyberSource/cybersource-rest-client-java#235 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
All issues in CyberSource/cybersource-rest-client-java
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
commonmark/commonmark-java#460 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
1.21.1见幽匿感测体就崩溃Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Make branch and label autocomplete matching locale-independentPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
jenkinsci/gitlab-plugin#1950 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
commons-app/apps-android-commons#6984 ·
Maintainers usually reply within 2 days