Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Bug in macro replacement in display

Open
  • Is something wrong?
#3,950 2 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
40/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
java
Domain
desktop

Research direction

Start by reproducing the nested-display case: a parent display passes P=QE1:FX4:, R=Current1:, and a child passes RN=$(R)TSTotal in the same macro list as R. Find where the Phoebus display runtime expands macros for child displays and check whether parameters are substituted in order, so later values see earlier replacements. Done when the plot title resolves to QE1:FX4:Current1:TSTotal and the ADL-converted and native .bob cases behave the same.

Written by the indexing model from the issue text.

Description

codathon discussion

I think I have found a bug in macro replacement in display files. In my case these are files that are converted from medm .adl files, but I think the problem is more general.

I originally saw the problem using the adl converter from Phoebus 4.6.10 and Phoebus display 4.7.3. But I have reproduced it using both the converter and display in Phoebus 6.0.0.

This is an example of the problem.

quadEM.bob loads the related display file NDStats, and passes the macro parameters P=QE1:FX4:, R=Current1:

NDStats.bob loads the related display file NDStatsTimeSeriesPlot, and passes the parameters P=$(P), R=$(R)TS:, RN=$(R)TSTotal

The title of this plot is $(P)$(RN)

Image

After substitution the plot title should thus be QE1:FX4:Current1:TSTotal.

However, it is not. As seen below it is QE1:FX4:Current1:TS:TSTotal.

Image

The reason is clear. This is the screen for the Actions of the menu that calls NDStatsTimeSeriesPlot:

Image

What is happening is that it is not using the original value of R when it builds RN, it is using the modified version from the first line.

I can work around the problem by swapping these 2 lines in the .adl file, so that RN is built before R. But it seems that this should be fixed in the translation or runtime engine.

Dominant language
Java
Stars
130
Forks
132
Avg merge
2d 11h
Merged PRs (30d)
23

Getting set up

  • No Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ControlSystemStudio/phoebus

All issues in ControlSystemStudio/phoebus

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.