fish completions are broken

Open Beginner friendly
#92 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
78/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
fish, go
Domain
cli

Research direction

Start by locating the fish completion output for cpak completion fish and the definitions for --mask-state and --device-dri. Check how their descriptions are quoted and compare with the other generated descriptions. The issue is resolved when fish --no-config --command 'cpak completion fish | source' runs without the reported errors.

Written by the indexing model from the issue text.

Description

cpak version: v2.14.18

Running this fails: fish --no-config --command 'cpak completion fish | source'

There are 2 types of errors it can give. 1. complete: too many arguments and 2. fish: Unknown command: foobar. Both are the result of the 1st one!

These 2 lines both have an unescaped ' inside the -d '[...] description. This completely breaks parsing of the following lines allow for the Unknown command errors.

complete -c cpak -n '__fish_seen_subcommand_from spawn' -l mask-state  -d 'a directory holding cpak's own state, to hide inside any grant that contains it'
complete -c cpak -n '__fish_seen_subcommand_from x11-broker' -l device-dri  -d 'allow the package's granted DRI device access'
Dominant language
Go
Stars
218
Forks
5
Avg merge
45m
Merged PRs (30d)
5

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Containerpak/cpak

All issues in Containerpak/cpak

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.