About 20% of fresh installs stay on the bundled ComfyUI v0.42.1 without saying so

Open
  • Is something wrong?
#1,978 2 comments 1 reaction 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
38/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
python, typescript
Domain
desktop

Research direction

Start with lib/update_comfyui.py for lock cleanup and r2Mirror.ts for the mirror-sync behavior; compare the GCS and R2 standalone-environments/latest.json copies. The issue describes several independent failure causes and suggested fixes, so first identify which one is being addressed. Done should include a fix for that failure and a check that installs no longer report success while remaining on an outdated core.

Written by the indexing model from the issue text.

Description

About one in five fresh Desktop installs never leaves the bundled ComfyUI. The bundle is v0.42.1 on every platform (standalone-environments/latest.json). Desktop shows the install as successful, so the user gets no sign it is outdated, and features that need a newer core stay off with no reason given.

It isn't a regression in 1.1.9: the share is about the same on 1.1.8 (roughly 20% on both). Most of these installs are Windows and Manual installs.

Causes seen so far
  1. A stale git lock left by the install itself. On Windows with 1.1.9 and an Express install, the version selection said v0.44.2, but the bundled v0.42.1 was installed. The follow-up update failed on .git/refs/tags/v0.0.3.lock, which was written during the install. "Update Now" failed the same way until the file was deleted by hand. lib/update_comfyui.py only clears HEAD.lock, index.lock, packed-refs.lock and refs/heads/master.lock. #1957 is the same gap for shallow.lock.
  2. A lagging PyPI mirror. With a mirror on, the requirements install for the newer core asks the mirror first and doesn't fall back to pypi.org. When the mirror hasn't synced the pinned comfyui-frontend-package, the update aborts, and the install stays on v0.42.1 while reporting success. Reproduced on Linux and Windows with a fake lagging index.
  3. The fallback for the bundled environments is stale. storage.googleapis.com/comfy-desktop-public/standalone-environments/latest.json still serves v0.29.0-env1 (core v0.28.0) on every platform, while the R2 copy serves v0.42.1. r2Mirror.ts says the mirror is "kept in sync at each release".
Suggested fixes
  • Clear any stale *.lock under .git/ (for example, older than a minute, with one git operation per install), not a fixed list. This also covers #1957.
  • When the update after install fails, tell the user, and retry on the next launch instead of reporting success.
  • Retry a failed uv resolve once against pypi.org.
  • Sync the GCS mirror on each environment release, and alert when it drifts from R2.
  • Record the reason for a failed post-install update in telemetry.
Dominant language
TypeScript
Stars
696
Forks
89
Avg merge
17h 45m
Merged PRs (30d)
209

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Comfy-Org/Comfy-Desktop

All issues in Comfy-Org/Comfy-Desktop

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.