Master Detail scroll into view
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- react, typescript
- Domain
- frontend
Research direction
Start by reproducing the Master Detail overflow case in the DataGrid using the listed steps, then trace the scroll-into-view behavior for the expanded detail row. Done means selecting or clicking detail-row content no longer triggers scrolling, while normal table-cell scroll-into-view behavior remains unchanged.
Written by the indexing model from the issue text.
Description
Describe the bug
The scroll into view mechanic for normal table cells works fine. However, when using the Master Detail pattern, scroll into view can be a poor design choice when DataGrid overflows.
Below is a quick video that demonstrates an overflowed DataGrid with Master Detail. The first few seconds is me horizontally scrolling with a trackpad. The quick left to right movement afterward occurs whenever I click on the expanded row. This happens because of scroll into view.
When trying to select text in the expanded row, it also causes the scroll into view to trigger multiple times, making it hard to read/select text.
To Reproduce
- Create DataGrid
- Add two columns with large width, enough to cause DataGrid to overflow scroll
- Add the Master Detail column
expandedkey withformatterthat has a similarly large width for the detail row - Add sample row
- Expand the row
- Click/select text on detail row
Expected behavior
Scroll into view should be disabled for detail rows.
Environment
react-data-gridversion: 7.0.0-beta.12react/react-domversion: 18
- Dominant language
- TypeScript
- Stars
- 7.7k
- Forks
- 2.2k
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 22
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Comcast/react-data-grid
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Comcast/react-data-grid#4045 ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
Comcast/react-data-grid#4184 ·
Maintainers usually reply within 1 day
-
[Bug] Duplicate frozen column elements in DOM and key collision warning when enableVirtualization={false}Possibly taken @nstepien claimed this 65 days ago. Open
Comcast/react-data-grid#4120 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
Comcast/react-data-grid#4004 · 4 comments ·
Maintainers usually reply within 1 day
-
Pinned Rows APIOpen
Difficulty 5/5 Over a week Newbie friendliness 35/100
Comcast/react-data-grid#3940 ·
Maintainers usually reply within 1 day
All issues in Comcast/react-data-grid
Similar issues
-
enhancement providers-api ui-dashboard
Difficulty 2/5 1-3 hours Newbie friendliness 61/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
external-issue to-triage
Difficulty 1/5 Under an hour Newbie friendliness 90/100
Maintainers usually reply within 1 day
-
needs triage
Difficulty 1/5 Under an hour Newbie friendliness 88/100
homarr-labs/homarr#6976 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day