FSE Design Pack editor notice never shows on WordPress 6.8+ (core renamed the pattern-inserted notice id)
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- javascript, wordpress
- Domain
- frontend
Research direction
Start with assets/js/src/components/DesignPackNotice.js and check how it reads core editor notices and identifies the pattern-inserted snackbar. Support the notice IDs used across WordPress versions while ensuring other inserter notices do not trigger the upsell. Confirm the notice appears after inserting a pattern on WordPress 6.7 and 6.8+, and not after inserting an image.
Written by the indexing model from the issue text.
Description
What's wrong
After you insert a pattern in the editor, Riverbank is supposed to show its "FSE Design Pack" upsell notice. Since WordPress 6.8 that notice never shows. Nothing errors and nothing is logged. It just doesn't appear.
The cause: assets/js/src/components/DesignPackNotice.js waits for a core notice with the id block-pattern-inserted-notice:
const BLOCK_PATTERN_INSERTED_NOTICE = 'block-pattern-inserted-notice';
// ...
.getNotices().filter( ( n ) => n.id === BLOCK_PATTERN_INSERTED_NOTICE ).length > 0
Core's block editor used that id from WordPress 6.3 to 6.7. From 6.8 onwards it uses inserter-notice for the same pattern-inserted snackbar (checked in the 6.8.1, 7.0.7 and 7.1.5 builds of wp-includes/js/dist/block-editor.js). So the theme waits for a notice that never comes.
Steps to reproduce
The quickest way to see it is side by side: one Playground where the notice works, one where it doesn't. Both sites are fresh, so the FSE Design Pack plugin isn't installed and the notice has never been dismissed.
- ✅ Works (WordPress 6.7): https://playground.wordpress.net/?wp=6.7&theme=riverbank&login=yes&url=/wp-admin/post-new.php?post_type=page
- ❌ Broken (latest WordPress): https://playground.wordpress.net/?wp=latest&theme=riverbank&login=yes&url=/wp-admin/post-new.php?post_type=page
In each one:
- Wait for the page editor to load. Collapse Playground's dark toolbar at the bottom (the ⌄ arrow next to "Autosaved"). The notice appears in the bottom-right corner, and the toolbar covers most of it.
- Click the blue + (Block Inserter) at the top left, open the Patterns tab, then pick a pattern category (the theme's own category, or any other).
- Click a pattern to insert it. Click it rather than dragging it onto the canvas: the theme only reacts to core's "pattern inserted" snackbar, and these steps were checked with a click.
On an existing site: the notice is skipped if the FSE Design Pack plugin is active, or once it has been dismissed. Dismissing it sets the option riverbank-design-pack-dismissed to yes. Delete that option, or use a fresh site.
Expected (what you see on 6.7)
About half a second after you insert the pattern, a white card slides in at the bottom right: the theme logo, "Riverbank recommends", "FSE Design Pack: Access a collection of 40+ layout patterns ready to import to your website", a blue Learn More button and an ×. Core's black "Block pattern "…" inserted." snackbar shows at the bottom left at the same time.
Actual (WordPress 6.8 and newer)
Core's snackbar shows (on 6.8+ it reads "Pattern "…" inserted."), but the card never appears. Nothing shows in the console, and the notice container (#riverbank-design-pack-notice) stays empty. The theme does load its script: window.designPackNoticeData is defined.
Found with Jaxon 1.0.13 on WordPress 7.1.5 (wp-env) and checked in Playground on 6.7 against the latest WordPress. Riverbank 1.0.18 has the same DesignPackNotice.js code on its default branch.
Suggested fix
Accept both ids, so it keeps working on 6.3 to 6.7 as well:
const PATTERN_NOTICE_IDS = [ 'block-pattern-inserted-notice', 'inserter-notice' ];
// ...
.filter( ( n ) => PATTERN_NOTICE_IDS.includes( n.id ) )
⚠️ Caveat: on 6.8+, core also uses inserter-notice for other inserter snackbars, such as "Image inserted.", "Image uploaded and inserted.", "Block "%s" can't be inserted." and the gallery attach/detach messages. Matching the id alone would also show the upsell after inserting an image. If the notice should only follow a pattern insertion, also check the text when the id is inserter-notice. For example, build a matcher from the same translated string core uses (__( 'Pattern "%s" inserted.' ) resolves through the shared default text domain):
const [ before, after ] = __( 'Pattern "%s" inserted.' ).split( '%s' );
const isPatternNotice = ( n ) =>
n.id === 'block-pattern-inserted-notice' ||
( n.id === 'inserter-notice' &&
typeof n.content === 'string' &&
n.content.startsWith( before ) &&
n.content.endsWith( after ) );
Same bug in the other FSE themes
- Codeinwp/neve-fse#214
- Codeinwp/raft#203
- Codeinwp/jaxon#119
- Codeinwp/fork#117
- Dominant language
- PHP
- Stars
- 2
- Forks
- 0
- Avg merge
- 4h 59m
- Merged PRs (30d)
- 5
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Codeinwp/riverbank
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
bug customer report
Difficulty 3/5 1-2 days Newbie friendliness 35/100
-
customer report new feature
Difficulty 4/5 3-5 days Newbie friendliness 45/100
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 35/100
All issues in Codeinwp/riverbank
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
sync-en
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
sync-en
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
Перевод устарел
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
nplhse/collaborative-ivena-statistics#1464 · 1 comment ·
Maintainers usually reply within 1 day