Guardrail - Report Lock with no worktime documented
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 70/100
Research direction
Look for the endpoint or service method that handles locking a contract month. Find where shifts are checked for locked=True and add a validation that at least one shift with reviewed=True exists. Return an appropriate HTTP error (like 400) if validation fails. Check existing tests for locking logic to understand the codebase.
Written by the indexing model from the issue text.
Description
So far we do not have a check whether a Contract has at least one shift that has reviewed=True in it's month.
Since the locked status is determined by the existence of at least one shift with locked=True we have the bug that user can indefinetly
try locking a month with zero shifts but it will never show as locked. In the meantime the time-vault gets flooded with meaningless
data.
- Implement check for at least one shift prior to locking
- Return reasonable HTTP error code
- Dominant language
- Python
- Stars
- 0
- Forks
- 4
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ClockGU/clock-backend
-
feature proposal
Difficulty 3/5 1-2 days Newbie friendliness 55/100
ClockGU/clock-backend#451 · 2 comments ·
-
:bug: Bug help wanted
Difficulty 3/5 1-2 days Newbie friendliness 45/100
ClockGU/clock-backend#435 ·
-
:bug: Bug
Difficulty 3/5 1-2 days Newbie friendliness 45/100
ClockGU/clock-backend#433 · 1 comment · 1 reaction ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
ClockGU/clock-backend#412 ·
-
enhancement low-priority
ClockGU/clock-backend#385 · 1 assignee ·
All issues in ClockGU/clock-backend
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
stephrobert/dsoxlab#238 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
sublimehq/package_control#1780 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
nwg-piotr/nwg-displays#145 ·