Update contract end date with locked shifts raises modified minutes error
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- python
- Domain
- backend-api-design
Research direction
Start at api/serializers.py lines 235-241 and reproduce the contract edit with locked and submitted shifts described in the issue. Trace why changing only the contract end date reaches the locked-shift minutes validation; done means the end date saves without that error while locked-shift minutes remain protected.
Written by the indexing model from the issue text.
Description
Observation
Users try to change their contract's end date routinely while locked shifts exist.
They receive and error "The minutes of a contract with locked shifts is not allowed to modify."
The error is raised here: https://github.com/ClockGU/clock-backend/blob/develop/api/serializers.py#L235-L241
Steps to reproduce
- Create a contract starting a month or so in the past
- Create some shifts in the 1st month
- Lock and submit
- Open the contract to edit and set a new end date
- Save - the error will appear
- Dominant language
- Python
- Stars
- 0
- Forks
- 4
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ClockGU/clock-backend
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
ClockGU/clock-backend#467 ·
-
feature proposal
Difficulty 3/5 1-2 days Newbie friendliness 55/100
ClockGU/clock-backend#451 · 2 comments ·
-
:bug: Bug help wanted
Difficulty 3/5 1-2 days Newbie friendliness 45/100
ClockGU/clock-backend#435 ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
ClockGU/clock-backend#412 ·
-
enhancement low-priority
ClockGU/clock-backend#385 · 1 assignee ·
All issues in ClockGU/clock-backend
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
stephrobert/dsoxlab#238 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
sublimehq/package_control#1780 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
nwg-piotr/nwg-displays#145 ·