Test and if necessary repair issues inserting `NULL` to get a default value when a column has an explicit `DEFAULT`
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 38/100
Research direction
Start with the NULL-handling block in src/binary.cpp at lines 429-443 and inspect the existing HTTP and binary driver tests and ClickHouse table definitions. Add cases using explicit DEFAULT values, including foreign PostgreSQL tables with and without constraints, then verify the drivers' NULL behavior and determine whether both should match.
Written by the indexing model from the issue text.
Description
From the ClickHouse Docs:
The expression
expris optional. If it is omitted, the column type must be specified explicitly and the default value will be0for numeric columns,''(the empty string) for string columns,[](the empty array) for array columns,1970-01-01for date columns, orNULLfor nullable columns.
Currently the binary driver refuses to insert a NULL into a non-Nullable column, but the http driver allows it. Add tests with explicit DEFAULT values on the ClickHouse tables and ensure that the http driver does the right thing when inserting a NULL (with and without a corresponding constraint on the foreign Postgres table).
Determine whether the binary driver behavior should be the same, and if so remove this block and fix issues accordingly:
- Dominant language
- C
- Stars
- 284
- Forks
- 21
- Avg merge
- 23h 1m
- Merged PRs (30d)
- 20
Getting set up
We have not checked this project's setup files yet. Start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ClickHouse/pg_clickhouse
-
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
ClickHouse/pg_clickhouse#383 · 1 comment ·
Maintainers usually reply within 1 day
-
data types enhancement
Difficulty 5/5 Over a week Newbie friendliness 35/100
ClickHouse/pg_clickhouse#380 ·
Maintainers usually reply within 1 day
-
enhancement functions pushdown
Difficulty 3/5 1-2 days Newbie friendliness 68/100
ClickHouse/pg_clickhouse#379 ·
Maintainers usually reply within 1 day
-
Push down joins against an aggregated `IN (SELECT … GROUP BY … HAVING)` subquery (TPC-H Q18 shape)Possibly taken @JoshDreamland claimed this 3 days ago. Openenhancement pushdown sql
ClickHouse/pg_clickhouse#378 · 1 assignee ·
Maintainers usually reply within 1 day
-
operators pushdown
Difficulty 3/5 1-2 days Newbie friendliness 65/100
ClickHouse/pg_clickhouse#375 ·
Maintainers usually reply within 1 day
All issues in ClickHouse/pg_clickhouse
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
BasedHardware/omi#19711 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
microsoft/ebpf-for-windows#5604 ·
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
trezor/trezor-firmware#7985 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day