Python drivers for graphite-web are not compatible with python 3
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
Research direction
Start in graphouse.py, focusing on the GraphouseReader init method and its fetch method. Check how Python 3 and the newer graphite-web driver interface handle path detection and fetch arguments, then verify that data can be displayed successfully after both compatibility issues are addressed.
Written by the indexing model from the issue text.
Description
New version of graphite-web is now supporting python 3.
I ve tried to setup everything and i was unable to display any data.
After looking in the driver ( and spending some time , i'm not a python dev , so apology if the vocabulary is not correct ) , i 've found 2 blocking issue in graphouse.py
1: in the init method of the graphouseReader, the way to detect if we have a collection or a string is not working ( hasattr(path, 'iter') is returning true on string , so it breaks everything, using something like isinstance(obj, collections.Sequence) should solve the issue )
2 : The fetch method is now taking 5 parameters instead of 3 ( self, start,stop,now,requestContext).
By fixing those 2 issues , i was able to make things work. But as i ve starting to learn python during the troubleshooting i don't feel really confortable to propose a fix.
Regards
- Dominant language
- Java
- Stars
- 260
- Forks
- 55
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ClickHouse/graphouse
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
ClickHouse/graphouse#150 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
ClickHouse/graphouse#140 · 1 comment ·
-
support for pickleOpen
Difficulty 5/5 Over a week Newbie friendliness 30/100
ClickHouse/graphouse#114 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
ClickHouse/graphouse#77 · 3 comments ·
-
Query PerformanceOpen
Difficulty 5/5 Over a week Newbie friendliness 15/100
ClickHouse/graphouse#75 ·
All issues in ClickHouse/graphouse
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Dans-Plugins/Medieval-Roleplay-Engine#396 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
LtByXsl throws NoSuchElementException when defect element has no text contentPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
objectionary/lints#1640 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
virtualcell/vcell#2193 ·
Maintainers usually reply within 1 day