Accept PodTemplate annotations
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- go, kubernetes
- Domain
- infrastructure
Research direction
Start from the ClickHouse CRD's PodTemplateSpec definition in the Go API types, and trace how the root-level annotations are currently copied onto pods and services. The issue asks for annotations to be accepted under the pod template, so the schema and the reconcile logic that applies them both need changing. Done means a pod template annotation reaches the pods without being added to the services, and the existing tests still pass.
Written by the indexing model from the issue text.
Description
Company or project name
No response
Use case
The annotations setup at root level of the CRD are passed to both pods and services, this leads to duplicated metrics scraping when prometheus has jobs to scrape both job="kubernetes-pods" and job="kubernetes-service-endpoints".
Describe the solution you'd like
In CRDs it would be nice to be able to also pass annotations in the PodTemplateSpec which is currently not allowed.
Describe alternatives you've considered
No response
Additional context
No response
- Dominant language
- Go
- Stars
- 310
- Forks
- 46
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 21
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ClickHouse/clickhouse-operator
-
feature
Difficulty 5/5 Over a week Newbie friendliness 35/100
ClickHouse/clickhouse-operator#293 · 1 comment ·
Maintainers usually reply within 1 day
-
Write migration paths/helper tools to the operator from bitnami helmchart/Altinity operatorMay be free again @GrigoryPervakov claimed this 70 days ago, and no pull request is open. Openfeature
ClickHouse/clickhouse-operator#272 · 3 comments · 1 assignee ·
Maintainers usually reply within 1 day
-
feat(controller): Allow for a configurable listen_host in network.yamlPossibly taken @arekborucki claimed this 119 days ago. Openfeature
Difficulty 4/5 3-5 days Newbie friendliness 48/100
ClickHouse/clickhouse-operator#217 · 1 comment ·
Maintainers usually reply within 1 day
-
feature
Difficulty 5/5 Over a week Newbie friendliness 35/100
ClickHouse/clickhouse-operator#196 · 3 comments ·
Maintainers usually reply within 1 day
-
feature
Difficulty 5/5 Over a week Newbie friendliness 35/100
ClickHouse/clickhouse-operator#144 · 2 reactions ·
Maintainers usually reply within 1 day
All issues in ClickHouse/clickhouse-operator
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
Schema validation is skipped when a transaction is invoked with a lowercase first letterPossibly taken @RaphaelFakhri claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
-
cmd/ebitenmobile: multi-language bindings run the complete generator twicePossibly taken @kumagi claimed this today. Openos:macos performance
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
hajimehoshi/ebiten#4011 · 1 comment ·
Maintainers usually reply within 1 day
-
agent-butler-finding chore
Difficulty 1/5 Under an hour Newbie friendliness 78/100
jordansmall/spindrift#6318 ·
Maintainers usually reply within 1 day