Refactor chain- and epoch-specific state manager tests into a dedicated file
Maintainers usually reply within 1 day
@akaladarshi is already working on this.
Since Oct 7, 2026.
Assessment
This issue has not been assessed yet.
Description
Summary
Move chain- and epoch-specific tests out of src/state_manager/utils.rs into a dedicated test file or test module. This is a follow-up refactor to PR #7709. It does not change state manager or RPC behavior.
Rationale
src/state_manager/utils.rs contains state-computation helpers and tests for specific network epochs. A dedicated test file will separate these responsibilities and make the snapshot-based tests easier to find and maintain.
Required changes
- Move
cargo_test_reward_distribution_calibnet_4109134into a dedicated test file or test module. - Move the related chain- and epoch-specific replay and state-validation tests from
state_compute::testsinto the dedicated test organization. - Review the generated state-computation test inclusion and keep generated tests discoverable.
- Keep reusable snapshot download and state preparation helpers available to the moved tests.
- Preserve test names, assertions, Tokio runtime settings, and
#[fickle::fickle]annotations.
Affected areas
src/state_manager/utils.rs, particularlystate_compute::tests.- The new dedicated state manager test file or test module.
- Test module declarations and generated-test inclusion, as needed.
Acceptance criteria
- Chain- and epoch-specific tests no longer reside in
src/state_manager/utils.rs. - The moved tests remain discoverable and retain their existing coverage.
- Snapshot loading, state-root checks, reward accounting assertions, and cache assertions remain unchanged.
- Relevant tests pass under the existing test workflow.
- No production state manager or RPC behavior changes.
References
- PR: https://github.com/ChainSafe/forest/pull/7709
- Review thread: https://github.com/ChainSafe/forest/pull/7709#discussion_r4207895548
- Requested by: @akaladarshi
- Dominant language
- Rust
- Stars
- 700
- Forks
- 201
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 65
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ChainSafe/forest
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Bug
Difficulty 3/5 1-2 days Newbie friendliness 20/100
Maintainers usually reply within 1 day
-
[automated] `cargo deny check advisories` failure @ 20/11/26 00:01Possibly taken @akaladarshi claimed this today. OpenBug
Difficulty 1/5 Under an hour Newbie friendliness 15/100
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 58/100
Maintainers usually reply within 1 day
-
FIP-0119 implementation in `builtin-actors`Possibly taken @LesnyRumcajs claimed this 2 days ago. OpenType: Task
ChainSafe/forest#7886 · 1 assignee ·
Maintainers usually reply within 1 day
All issues in ChainSafe/forest
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
benchmark-review
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
app-request
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
flatpark/flatpark#1423 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
area:image documentation good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day