Consider CAR-first reading
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 35/100
Research direction
Start with src/db/car/many.rs at lines 226-239, where ParityDb is checked before the CAR files. Measure both lookup orders on snapshot export and RPC-serving workloads, including lock contention and relevant performance metrics. Done means deciding which approach should be the default, with any option to reverse it supported if the measurements warrant that.
Written by the indexing model from the issue text.
Description
Summary
Right now we check ParityDb first, only then the CAR files.
The issue is that this internally harasses an internal ParityDb RwLocks - 4 global ones and then some processing. Flipping it (and potentially replacing our RwLock with ArcSwap) could make the entire thing operate more smoothly with less lock contention. In theory this could make certain workloads slower (if operating purely on hot data); it's worth measuring on expected use-cases, e.g., snapshot export and RPC serving. Some additional metrics would be useful as well.
We could also have an option to flip back the behavior.
Completion Criteria
- Decide whether
ParityDbfirst or CAR-first approach is a better default.
Additional Links & Resources
- Dominant language
- Rust
- Stars
- 700
- Forks
- 201
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 65
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ChainSafe/forest
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Bug
Difficulty 3/5 1-2 days Newbie friendliness 20/100
Maintainers usually reply within 1 day
-
[automated] `cargo deny check advisories` failure @ 20/11/26 00:01Possibly taken @akaladarshi claimed this today. OpenBug
Difficulty 1/5 Under an hour Newbie friendliness 15/100
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 58/100
Maintainers usually reply within 1 day
-
FIP-0119 implementation in `builtin-actors`Possibly taken @LesnyRumcajs claimed this 2 days ago. OpenType: Task
ChainSafe/forest#7886 · 1 assignee ·
Maintainers usually reply within 1 day
All issues in ChainSafe/forest
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
benchmark-review
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
app-request
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
flatpark/flatpark#1423 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
area:image documentation good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day